-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Save button stop working issue #1269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the intended logic when adding a component with the API Key of `form`. Errors in that logic prevented the notification from displaying and prompting the form designer to remove that component. Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Save Button stops working.
jasonchung1871
approved these changes
Feb 8, 2024
WalterMoar
reviewed
Feb 12, 2024
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
WalterMoar
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
nimya-aot
added a commit
to nimya-aot/common-hosted-form-service
that referenced
this pull request
May 27, 2024
nimya-aot
added a commit
that referenced
this pull request
Jun 3, 2024
* #FORMS-974 * #974 updates * #980 modification to cypress config * FORMS-980 * #992 * #992 Fix cypress scripts * #1011 Form design page * #1011 test scripts * #1023 cypress scripts * #1023 advanced data components * #1023 Updated scripts * #1023 updation * Updated json file * Test/forms (#1011)(#1023) (#1307) * #FORMS-974 * #974 updates * #980 modification to cypress config * FORMS-980 * #992 * #992 Fix cypress scripts * #1011 Form design page * #1011 test scripts * #1023 cypress scripts * #1023 advanced data components * #1023 Updated scripts * #1023 updation * Updated json file * #1059 workflow file for cypress * #1059 updated the base url * #1059 updated workflow * Updated node version * updated * updated * Updation * updated file * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * updated package file * Update cypress-ci.yaml * Updated config file * Update cypress-ci.yaml * #1059 updated package * #1060 scripts for Advanced fields and BC Gov components * Fixing review comments * Updated changes * # Updated with PR comments * updated * Update form-design-basicfields.cy.js * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Update cypress-ci.yaml * Modifies test scripts * Updated files * Fixed errors during CI/CD Run * Updated browser type * Updated Simple BC address component * Updated * Fields updated * Test script changed * Updated * Updated fields * Updated env variable * Update form-design-basicfields.cy.js * Updated * Update cypress-ci.yaml * Updated email input * screenshots * Updated path * Update cypress-ci.yaml * Update cypress-ci.yaml * Updated version on workflow * Fix to failed tests * Fix to BC address component * Updated the component * Changed button element * Fixed BC components * Modified submission * Modified components * Updated attribute * Updated * Changed simpleBC address component * cleared * Removed package * screenshot folder updated * Updated id for email notification * Updated email input id * Updated scripts according to PR review * #1269 updated PR env variable * updated * updated * Updated home page content visibility * reverted changes * changed * Updated scripts * updated * null pr number * changed pr env * updated * changed * updated * updated * changed url * updated url * log added * updated * updated * updated * Updated scripts * updated * Updated with PR review comments * updated * updated --------- Co-authored-by: jasonchung1871 <101672465+jasonchung1871@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the intended logic when adding a component with the API Key of
form
. Errors in that logic prevented the notification from displaying and prompting the form designer to remove that component.See FORMS-982.
The issue reported was save button stops working.
CHEFs did (intend to) have a prompt to notify the designer that they cannot save a component with API key =
form
. That's where the button gets disabled. Without the prompt the designer doesn't know how much work or how many components would be lost to reset the button by clickingUndo
.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
Steps to reproduce (on existing code - use the dev instance)
On this PR, at step 7 you should see an error notification indicating you cannot have a component named
form
. The component is in the form, so remove it or clickUndo
. You should then see the save button enabled and carry on adding/editing as before.