Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Update ProactiveHelp to use a tooltip #1490

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jasonchung1871
Copy link
Collaborator

Description

ProactiveHelp was updated to include the key of the object and not just the simple text, each component has a unique key we can use to identify what component it is. When hovering over a component in the builder sidebar, a tooltip should pop up. Clicking the tooltip will pop up the proactive help.. This needs to be heavily optimized, but this is a proof of concept.

Types of changes

ProactiveHelp eventually stopped working.. We're unable to make changes to the HTML DOM. Instead, we're hovering over the entire HTML, checking if we're hovering over the sidebar, then showing a tooltip if we are. Clicking on the tooltip will pop up the proactive help.

feat (a new feature)
fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

ProactiveHelp was updated to include the key of the object and not just the simple text, each component has a unique key we can use to identify what component it is. When hovering over a component in the builder sidebar, a tooltip should pop up. Clicking the tooltip will pop up the proactive help.. This needs to be heavily optimized, but this is a proof of concept.

This comment has been minimized.

Added some default values for a component

This comment has been minimized.

hovering over the form component in the sidebar will show the tooltip, hovering away from it will hide it, clicking outside will hide it.
Cleaned up the ProactiveHelpPreviewDialog to use more of the vuetify components if we can.
The tooltip has an arrow on it pointing to the component that was hovered over

This comment has been minimized.

Set the tooltip to the right of the component.. appears to be working now.
Copy link

github-actions bot commented Sep 9, 2024

@jasonchung1871 jasonchung1871 changed the title Update ProactiveHelp to use a tooltip draft: Update ProactiveHelp to use a tooltip Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant