refactor: Forms 1533 bulk upload separation #1528
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request puts us closer to utilizing tree-shaking that Vue 3 provides. It also adds fills some of our technical debt in regards to testing for the front end. This separates the bulk upload functionality found in the FormViewer out into the FormViewerMultiUpload file where it should have been originally. This reduces the complexity of FormViewer since the bulk upload wasn't necessary for it to work. This also converts the FormViewerMultiUpload file from the options API to the composition API.
Summary: The code for bulk upload has been removed from FormViewer and placed into FormViewerMultiUpload. There were some minor changes like variable names or function names, just to make things clearer, and added comments. The delay function was moved out into a composable function so that it could be mocked in the test. Options API to composition API changes are changes made in how a variable is accessed, going from
this.variable = 0
tovariable.value = 0
.Type of Change
refactor (change to improve code quality)
test (add missing tests or correct existing tests)
Checklist
Further comments