build: FORMS-1679 remove unused components dependencies #1554
Conversation
This comment has been minimized.
This comment has been minimized.
WalterMoar
requested review from
usingtechnology,
bhuvan-aot,
abhilash-aot,
nimya-aot,
jasonchung1871 and
RyanBirtch-aot
| "test:coverage": "nyc --reporter=text mocha --reporter spec './{,!(node_modules)/**/}*.spec.js'", | ||
| "test": "mocha --require ts-node/register --reporter spec './{,!(node_modules)/**/}*.spec.ts'", |
There was a problem hiding this comment.
Since we don't have tests for the components, removing these scripts allows us to further reduce the number of dependencies.
We don't have tests for these components, so also removing the tests script to remove even more dependencies.
WalterMoar
force-pushed
the
build/1679-remove-components-dependencies
branch
from
f084dc9 to
a30a024
Compare
| @@ -49,43 +46,26 @@ | |||
| "dependencies": { | |||
| "@types/leaflet": "^1.9.12", | |||
| "@types/leaflet-draw": "^1.0.11", | |||
| "autocompleter": "^7.0.1", | |||
| "css-loader": "^7.1.2", | |||
There was a problem hiding this comment.
Note: css-loader is needed, but moving it to the devDependencies.
| "lodash": "^4.17.21", | ||
| "native-promise-only": "^0.8.1", | ||
| "path-browserify": "^1.0.1", | ||
| "webpack": "^5.75.0" |
There was a problem hiding this comment.
Note: webpack is needed, but moving it to the devDependencies.
|
I can run cypress tests on this env https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1554 if all these changes deployed there |
That would be great! The PR environment has just been updated with moving a couple of packages to the dev dependencies. |
|
@WalterMoar form.io components seems to be working . But a few of the tests are failing since my email id is not exist on Manage team section. Can someone add me to the CHEFS keycloak group on which PR env is running? |
I think that error message is saying that you need to log into the PR environment. That will create your user in CHEFS and then it will appear in the search. |
|
@WalterMoar Thanks for the info. Now its working good. |
It’s a best practice to have as few dependencies as possible. The “components” project that houses the form.io components has many packages in its dependencies that don’t appear to be used. Remove whatever is not needed.
Acceptance Criteria
Description
Type of Change
build (change in build system or dependencies)
Checklist
Further comments
Including the dev dependencies this reduces the package count from 656 to 461. A side effect is that it will probably get rid of some security vulnerabilities picked up by dependabot.