Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: FORMS-1681 fix production url in push action #1555

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

WalterMoar
Copy link
Collaborator

Description

The on_push Action displays the URL of the deployed environment for dev, test, and production. However, we use the vanity URL submit.digital.gov.bc.ca, which is not what is displayed in the Action:

image

Acceptance Criteria

  • The URL in the production deployment is the proper URL of the app.

Type of Change

ci (change in continuous integration / deployment)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

@WalterMoar WalterMoar marked this pull request as ready for review December 24, 2024 17:25
@WalterMoar WalterMoar merged commit 6cebb6a into bcgov:main Dec 24, 2024
5 checks passed
@WalterMoar WalterMoar deleted the build/1681-actions-prod-url branch December 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant