Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: FORMS-1597 update owasp zap scan action #1558

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

WalterMoar
Copy link
Collaborator

Description

GitHub has announced that after January 30th, 2025, their Action upload-artifact v3 will no longer run. This v3 has been deprecated for some time, but the Action we use to run the OWASP ZAP Scan did not get updated to v4 until November 21st, 2024. We are using v0.10.0, update to v0.12.0 to fix the problem.

Acceptance Criteria

  • There are no deprecation warnings or failures from upload-artifact when the OWASP ZAP Scan runs

Type of Change

ci (change in continuous integration / deployment)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

The OWASP ZAP Scan action v0.10.0 uses the deprecated upload-artifact v3 GitHub Action.
@WalterMoar WalterMoar marked this pull request as ready for review December 27, 2024 22:01
@WalterMoar WalterMoar merged commit 46b346a into bcgov:main Dec 27, 2024
5 checks passed
@WalterMoar WalterMoar deleted the ci/1597-update-owasp-action branch December 27, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant