Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 #157

Merged
merged 6 commits into from
May 6, 2022
Merged

Vue3 #157

merged 6 commits into from
May 6, 2022

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented May 6, 2022

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

chore

Additional Notes:

I had these from before adding the linting rules which is why the format style is old. Might make sense to merge in and then do a single reformatting pull request on all the files. Covers:

  • ContinueBar
  • CurrencyInput
  • ContentModal

@@ -130,13 +130,14 @@ export default {
}
}
},
emits: ['update:modelValue', 'input', 'blur'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break these down with each on its own line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just left a comment that I had these changes from before the linting rules, didn't run the linter on them to keep the diff small, I was thinking we could bring this in and then run the linter on all files in one pull request without logic changes to make it easier. But could just lint too in this pr if preferable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that here though, the last commit is just linting rules, the component commits show the logic changes alone

Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm kind of on the fence with some of the new linting rules. I guess there's places where it looks nice, and others where it doesn't. We can maybe debate this later.

@jlangy jlangy merged commit afc3c65 into v2 May 6, 2022
@jlangy jlangy deleted the vue3 branch May 6, 2022 18:14
@jlangy
Copy link
Contributor Author

jlangy commented May 6, 2022

I agree, probably will want to adjust. Would be nice to get team agreements for a good set in vue projects that we can all agree on and just use the same .eslintrc file across projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants