Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digit input #161

Merged
merged 3 commits into from
May 9, 2022
Merged

Digit input #161

merged 3 commits into from
May 9, 2022

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented May 9, 2022

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

chore

Additional Notes:

bryce-mcmath
bryce-mcmath approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but see my comment on my PostalCode PR, you might want to add the input.stop

harrymaynard-maximus
harrymaynard-maximus approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jlangy jlangy merged commit 12cb367 into v2 May 9, 2022
@jlangy jlangy deleted the digit-input branch May 9, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryce-mcmath bryce-mcmath bryce-mcmath approved these changes

@harrymaynard-maximus harrymaynard-maximus harrymaynard-maximus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlangy @bryce-mcmath @harrymaynard-maximus