Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page stepper #174

Merged
merged 4 commits into from
May 12, 2022
Merged

Page stepper #174

merged 4 commits into from
May 12, 2022

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented May 12, 2022

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

chore

Additional Notes:

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the attributes and listeners still be applied to that created tag? Did you test that?

@jlangy
Copy link
Contributor Author

jlangy commented May 12, 2022

I tested the tag and the slot content, good point though I will extend the testing to make sure any attributes and listeners come through

@jlangy
Copy link
Contributor Author

jlangy commented May 12, 2022

I added some tests for that (linted the pagestepper too), it's using some vue magic with fallthrough attributes which looks odd, I put in the comment to the docs explaining why it works though.

The reason I switched from createElement is it changed to a global import (instead of the first arg to the render function) in vue-3, which was causing issues related to vue being imported twice with jest and storybook.

Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jlangy jlangy requested a review from bryce-mcmath May 12, 2022 19:50
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jlangy jlangy merged commit 40c208d into v2 May 12, 2022
@jlangy jlangy deleted the page-stepper branch May 12, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants