-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page stepper #174
Page stepper #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the attributes and listeners still be applied to that created tag? Did you test that?
I tested the tag and the slot content, good point though I will extend the testing to make sure any attributes and listeners come through |
I added some tests for that (linted the pagestepper too), it's using some vue magic with fallthrough attributes which looks odd, I put in the comment to the docs explaining why it works though. The reason I switched from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Please check if the PR fulfills these requirements:
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
chore
Additional Notes: