Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required attrs to inputs, add button role to fileuploader #187

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

bryce-mcmath
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Requested a11y changes (required attributes and role attribute)

Additional Notes:

@bryce-mcmath
Copy link
Contributor Author

Will have to include these changes in the v3 branch as well

Copy link
Contributor

@jlangy jlangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of the selects don't have aria-required, just the required attribute. Is that intentional?

@bryce-mcmath
Copy link
Contributor Author

Looks good, a couple of the selects don't have aria-required, just the required attribute. Is that intentional?

RegionSelect and CountrySelect are wrappers around the VueRegionSelect and VueCountrySelect components, so the aria-required isn't applied on the wrappers, only the components underneath

@bryce-mcmath bryce-mcmath merged commit 06d9aaf into main Jul 13, 2022
@bryce-mcmath bryce-mcmath deleted the a11y-2 branch July 13, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants