Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress values to RegionSelect, CountrySelect #192

Merged
merged 7 commits into from
Aug 4, 2022

Conversation

stephanieharrison-maximus
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • [] Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Adds data-cy values to the RegionSelect and CountrySelect components for Cypress testing.

Additional Notes:

I didn't add tests due to the minor-ness of the change, but I can if desired.

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When you're done and you've published a patch version, please checkout the v3 branch and merge main into it, then fix the conflicts if there are any and publish an alpha version of the v3 branch

(to keep v3 up to date with the main version)

@cyrilbravo
Copy link
Collaborator

Changes looks good. Approved :)

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing that

@cyrilbravo
Copy link
Collaborator

The new commits looks good. Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants