-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress values to RegionSelect, CountrySelect #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. When you're done and you've published a patch version, please checkout the v3 branch and merge main into it, then fix the conflicts if there are any and publish an alpha version of the v3 branch
(to keep v3 up to date with the main version)
Changes looks good. Approved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing that
The new commits looks good. Nice job! |
Please check if the PR fulfills these requirements:
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
Adds data-cy values to the RegionSelect and CountrySelect components for Cypress testing.
Additional Notes:
I didn't add tests due to the minor-ness of the change, but I can if desired.