Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress address doctor v3 #194

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Cypress address doctor v3 #194

merged 4 commits into from
Aug 9, 2022

Conversation

stephanieharrison-maximus
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Adds cypress values to a bunch of stuff that needs it

Additional Notes:

cyrilbravo
cyrilbravo approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@cyrilbravo cyrilbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added fixes look good. Approved :)

@stephanieharrison-maximus stephanieharrison-maximus deleted the cypress-address-doctor-v3 branch August 9, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilbravo cyrilbravo cyrilbravo approved these changes

@bryce-mcmath bryce-mcmath bryce-mcmath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanieharrison-maximus @bryce-mcmath @cyrilbravo