Address doctor subtitle #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanieharrison-maximus
requested review from
bryce-mcmath and
cyrilbravo
cyrilbravo
approved these changes
Sep 22, 2022
bryce-mcmath
suggested changes
Sep 22, 2022
bryce-mcmath
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
Introduces ability to add a subtitle and/or placeholder text to the Address Doctor Input component. Also formatted some unit tests.
Additional Notes:
I looked into a few ways to potentially unit test these changes and ultimately decided against it. They'd come too close to implementation detail tests for my comfort, but I'm open to adding them if there's disagreement on that.