Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Historical and Exempt Status text doesn't appear in status column in MHR rows #15910

Closed
tlebedovich opened this issue Apr 7, 2023 · 12 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@tlebedovich
Copy link

The the MHR table (logged in as Staff)

I tried both the Exempt and Historical Status Filters, and each filter listed results, but the MHRs did not have the Status type listed in their rows.

Historical:

Screen Shot 2023-04-06 at 5.25.05 PM.png

Exempt:

Screen Shot 2023-04-06 at 5.24.18 PM.png

@tlebedovich tlebedovich added Assets bug Something isn't working labels Apr 7, 2023
@mstanton1
Copy link
Collaborator

Note: Status is not showing prior to filter either. It appears the only status showing is Active.

@tlebedovich
Copy link
Author

tlebedovich commented May 8, 2023

@mstanton1 @chdivyareddy - so I found an older "status" requirements spreadsheet from @forgeuxGH5 and it seems like the main Status of the parent MHR row (Active, Exempt, Historical) should not be linked to the statuses that show for the child rows. I think we need to check in with Scott tomorrow to confirm what should be appearing for the child rows based on the type of child row.

The requirements doc is pretty old and may not be complete. But it does look like the Parent MHR row's status should not automatically extend to all the child row's statuses.

We may need a design ticket to review child row statuses based on transaction type. This may take some time as we know there are a lot.

Here is the older requirements doc I found that Scott had made - https://1drv.ms/x/s!AlejmOwhCCvlgcAOZEyqC5JISmFBPA?e=QS3lfs

@tlebedovich
Copy link
Author

tlebedovich commented May 8, 2023

@mstanton1 @chdivyareddy - maybe to keep this ticket moving along, we just make sure the MHR parent status appears in just the MHR parent row for Exempt and Historical homes and keep the child row statuses empty for Exempt and Historical for now and make a follow up design/dev ticket for all child row status types?

@mstanton1
Copy link
Collaborator

@tlebedovich good call. I have created 16286 for the UI Design but it should have requirements reviewed / confirmed before any work is done. I will add that to the to-do list for Louise and Catherine when time allows.

@tlebedovich
Copy link
Author

Agreed - thank you!

@chdivyareddy
Copy link
Collaborator

@tlebedovich @mstanton1 thanks for the input!

Hey @orelbn , can you please update the child row statuses empty for Exempt and Historical for now to keep this ticket moving, thanks!!

Screenshot 2023-05-09 at 9.24.31 AM.png

@orelbn
Copy link

orelbn commented May 9, 2023

Sure, will get on that.

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

image.png

image.png

@chdivyareddy
Copy link
Collaborator

Hey @orelbn , this change to the child row statuses empty for Exempt and Historical is not reflected in TEST after the deployment to TEST, was there any database changes as part of this ticket?

image.png

@orelbn
Copy link

orelbn commented May 16, 2023

There were no changes to the database as part of the ticket.

@chdivyareddy
Copy link
Collaborator

Looks like there was some deployment issue, thanks for confirming Orel:)

@chdivyareddy
Copy link
Collaborator

Verified in TEST!

image.png

@PCC199 PCC199 closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants