-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not show exempt and historical children + Code clean up #1330
Conversation
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1330-lrs9k4mo.web.app |
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
- Coverage 72.35% 72.27% -0.08%
==========================================
Files 307 313 +6
Lines 12767 13038 +271
Branches 2630 2728 +98
==========================================
+ Hits 9237 9423 +186
- Misses 3518 3603 +85
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks great!
Just had one comment/question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
Issue #: /bcgov/entity#15910
Description of changes:
getStatusDescription
to avoid looping and simplify codeaddHistoryDraftsToMhr
function to false, has it causes "* Draft Changes" to display when filtering by draft statusType for drafts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).