Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not show exempt and historical children + Code clean up #1330

Merged
merged 3 commits into from
May 11, 2023

Conversation

orelbn
Copy link
Contributor

@orelbn orelbn commented May 10, 2023

Issue #: /bcgov/entity#15910

Description of changes:

  • Adds condition to check for exempt and historical children statusTypes and return an empty string
  • Utilizes a map/object in the getStatusDescription to avoid looping and simplify code
  • changes the hasDraft condition inthe addHistoryDraftsToMhr function to false, has it causes "* Draft Changes" to display when filtering by draft statusType for drafts.
  • Adds and updates tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@orelbn
Copy link
Contributor Author

orelbn commented May 10, 2023

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1330-lrs9k4mo.web.app

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1330 (98266cc) into main (9255e77) will decrease coverage by 0.08%.
The diff coverage is 67.56%.

@@            Coverage Diff             @@
##             main    #1330      +/-   ##
==========================================
- Coverage   72.35%   72.27%   -0.08%     
==========================================
  Files         307      313       +6     
  Lines       12767    13038     +271     
  Branches     2630     2728      +98     
==========================================
+ Hits         9237     9423     +186     
- Misses       3518     3603      +85     
  Partials       12       12              
Flag Coverage Δ
pprui 72.27% <67.56%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pr-ui/src/components/common/CertifyInformation.vue 79.45% <ø> (ø)
ppr-ui/src/components/dialogs/BaseDialog.vue 100.00% <ø> (ø)
...ui/src/components/dialogs/common/DialogButtons.vue 100.00% <ø> (ø)
.../mhrRegistration/HomeLocation/HomeCivicAddress.vue 83.87% <ø> (ø)
...i/src/components/mhrTransfers/DeathCertificate.vue 97.72% <ø> (ø)
...rc/components/mhrTransfers/SupportingDocuments.vue 100.00% <ø> (ø)
.../components/mhrTransfers/TransferDetailsReview.vue 100.00% <ø> (ø)
...pr-ui/src/components/mhrTransfers/TransferType.vue 59.32% <0.00%> (ø)
...r-ui/src/components/tombstone/TombstoneDefault.vue 100.00% <ø> (ø)
...c/composables/mhrRegistration/useMhrValidations.ts 38.88% <0.00%> (-1.12%) ⬇️
... and 51 more

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks great!
Just had one comment/question.

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

ppr-ui/src/composables/useRegistration.ts Show resolved Hide resolved
@cameron-eyds cameron-eyds merged commit 75256e8 into bcgov:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants