Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business Search: Add Good Standing in COLIN #15978

Closed
19 of 21 tasks
thorwolpert opened this issue Apr 18, 2023 · 9 comments
Closed
19 of 21 tasks

Business Search: Add Good Standing in COLIN #15978

thorwolpert opened this issue Apr 18, 2023 · 9 comments
Assignees
Labels
BTR Business Transparency Register Search Search team development issues

Comments

@thorwolpert
Copy link
Collaborator

thorwolpert commented Apr 18, 2023

Business Search: Add Good Standing

BACKGROUND

Given The user is logged in
And has the appropriate payment methods enabled

Scenario: API returns Good Standing

When a search has been done on a business
Then the results has the Good Standing field set as either True or False for all modernized businesses and all COLIN BCA businesses not in the NWPTA agreement. For all other business types the field will not be present in the response.

Details

  • Update COLIN API
  • Update SOLR_FEEDER
  • Update SEARCH-API
  • Update SOLR
  • Update IMPORTER (will need to calculate good standing for every record)
    • COLIN
    • LEAR
  • Update UPDATER (augment test only -- should pickup change automatically)
  • Ensure/update COLIN triggers are working on a 'good standing' change for all business types
  • Create job/event that calculates good standing for LEAR (run daily)? Might not need - could be covered in importer changes verified covered by importer
  • oracle corporation trigger update (last_ar_filed_dt, transition_dt) Work with David R
    • dev
    • test
    • prod
  • sandbox deployment / verification
    • update OCP config to pull from integration db
    • update connection policy on integration db to allow OCP connection
    • update db in sandbox (hasn't got any migrations since 10 months ago)
    • deploy current legal-api image in sandbox (for db updates etc.)
    • run business search sandbox deploy/verify
  • update api documentation
@thorwolpert thorwolpert added the Search Search team development issues label Apr 18, 2023
@forgeuxGH5
Copy link
Collaborator

do we need a design ticket for this?

@thorwolpert
Copy link
Collaborator Author

For the API and to meet MoForests needs, no.

For the UI, I think it would save a lot of grief to do that up front.

@kialj876
Copy link
Collaborator

kialj876 commented Apr 19, 2023

So for the UI this would be adding a good standing indicator inside each row of the results right?

do we need a design ticket for this?

I think we do, yes

@thorwolpert
Copy link
Collaborator Author

Could we add to the API call sooner than later? It has a big impact on the MoFor workflow, so a large business value

@kialj876
Copy link
Collaborator

kialj876 commented Apr 19, 2023

I think in order to do this well in the UI we will have to add it to the api response, which will mean adding it to the solr index, etc.

MoFor are wanting that information in the facets response right?

@thorwolpert
Copy link
Collaborator Author

Yep, I don't think it's a particularly small add, since it touches everything in the chain

@forgeuxGH5
Copy link
Collaborator

Ok - I'd need to get a design ticket in and prioritised

@steveburtch
Copy link

@janisrogers we want to release this COLIN API change (in good standing) next week but we will need some help to test it from someone who knows the business rules around good standing for BCA companies. Would you be able to help us with this or point us to who can? @kialj876 @patrickpeinanw @gunanagar

@kialj876
Copy link
Collaborator

kialj876 commented Sep 21, 2023

Oracle trigger change in linked merged PR below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register Search Search team development issues
Projects
None yet
Development

No branches or pull requests

6 participants