Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colin-api: good standing bug fix #2208

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

kialj876
Copy link
Collaborator

Issue #: /bcgov/entity#15978

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 self-assigned this Sep 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2208 (b978b36) into main (d024a87) will decrease coverage by 9.70%.
Report is 16 commits behind head on main.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
- Coverage   76.97%   67.28%   -9.70%     
==========================================
  Files         160      193      +33     
  Lines        9793    12497    +2704     
  Branches     1654     1651       -3     
==========================================
+ Hits         7538     8408     +870     
- Misses       1797     3631    +1834     
  Partials      458      458              
Flag Coverage Δ
colinapi 32.29% <76.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
colin-api/src/colin_api/__init__.py 97.22% <100.00%> (ø)
colin-api/src/colin_api/resources/__init__.py 100.00% <100.00%> (ø)
colin-api/src/colin_api/resources/business.py 36.27% <100.00%> (ø)
colin-api/src/colin_api/resources/event.py 41.17% <100.00%> (ø)
colin-api/src/colin_api/resources/filing.py 22.12% <100.00%> (ø)
colin-api/src/colin_api/resources/office.py 47.22% <100.00%> (ø)
colin-api/src/colin_api/resources/parties.py 43.63% <100.00%> (ø)
...lin-api/src/colin_api/resources/program_account.py 58.62% <100.00%> (ø)
colin-api/src/colin_api/resources/reset.py 56.00% <100.00%> (ø)
colin-api/src/colin_api/resources/share_struct.py 48.57% <100.00%> (ø)
... and 10 more

... and 16 files with indirect coverage changes

@kialj876 kialj876 merged commit e7545b7 into bcgov:main Sep 28, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants