Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Wysiwig Editor #16133

Closed
mstanton1 opened this issue Apr 27, 2023 · 8 comments
Closed

UI - Wysiwig Editor #16133

mstanton1 opened this issue Apr 27, 2023 · 8 comments

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Apr 27, 2023

  • replace tiptapvuetify with tiptap vue2
  • replacing ahead of time so we can upgrade to vue3 - as there is a vue3 version
  • must be backwards compatible so formatting from previous PPR registrations that were done using the tiptapvuetify wysiwig can be retained
  • include some data sanitization, in an effort to secure all data sent to the server.
  • See package: https://www.npmjs.com/package/v-sanitize

https://tiptap.dev/installation/vue2

Note: Goal is to replace the Wysiwig as is. However, if there are features that can be addressed from design that were not originally included, and scope is minimal, those should be tackled. Original UI Design is below.

https://app.zenhub.com/workspaces/assets-team-space-61426544e7e2ea001d079597/issues/gh/bcgov/entity/12018

@saragunnarsson
Copy link
Collaborator

saragunnarsson commented Jun 23, 2023

Hey @cameron-eyds Just a couple things noted below:

  • Double check the font-sizes for the headings. H1 is too big, and H3 has too much line-height...H2 seems good, but since it’s in rem I can’t say for sure

  • The hairline needs 20px padding top and bottom

  • The little corner icon for the user to drag the box bigger and make it bigger is not there
    image.png

@cameron-eyds
Copy link
Collaborator

@saragunnarsson Sounds good, thanks for the review!
The only thing i'm not sure is possible with the current tool is the ability to drag/collapse it for resize.
I can look into if/how this might be supported.

@saragunnarsson
Copy link
Collaborator

@cameron-eyds Ok sounds good! If it works, great, if not, that should be fine. I'll pop this back in progress

@saragunnarsson
Copy link
Collaborator

Looks good @cameron-eyds ! Moving along

@saragunnarsson
Copy link
Collaborator

@cameron-eyds Sorry, one more thing!

Set H1, H2, H3 icons to: font-size: 17px, color : #495057
Set the rest of the icon font-sizes to: 21px - color : #495057
image.png

@cameron-eyds
Copy link
Collaborator

@saragunnarsson Sounds great, thank you!
Adjustments are done and currently in code review :)

@saragunnarsson
Copy link
Collaborator

@cameron-eyds Nice one, thank you!

@chdivyareddy
Copy link
Collaborator

As we have 16136 for testing Wysiwig editor, moving this ticket to Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants