Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt Wysiwyg Implementation #1395

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Alt Wysiwyg Implementation #1395

merged 6 commits into from
Jun 23, 2023

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#16133

Description of changes:

  • Builds a new wysiwyg editor using TipTap Editor and various extensions.
  • The purpose of this update editor, is it has a vue 3 supported instance of the editor, so alleviate the scope during vue upgrade process.
  • Includes some design features outlined in design: https://projects.invisionapp.com/share/W312QYCNE56Z#/screens/467365020
  • The above includes: Enhanced/organized toolkit, headers, clear functionality and formatting.

Notes:

  • This commit incudes a new feature flag to toggle between the old and new wysiwyg editor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jun 22, 2023
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

1 similar comment
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@cameron-eyds
Copy link
Collaborator Author

Currently expanding on unit testing for when we remove the old editor 👍

@cameron-eyds cameron-eyds changed the title Wysiwyg Implementation Alt Wysiwyg Implementation Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #1395 (4b83997) into main (9255e77) will increase coverage by 4.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   72.35%   76.94%   +4.59%     
==========================================
  Files         307      325      +18     
  Lines       12767     6039    -6728     
  Branches     2630      957    -1673     
==========================================
- Hits         9237     4647    -4590     
+ Misses       3518     1359    -2159     
- Partials       12       33      +21
Flag Coverage Δ
pprui 76.94% <100.00%> (+4.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ppr-ui/src/components/common/BaseSnackbar.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/ButtonsStacked.vue 100.00% <ø> (+12.50%) ⬆️
ppr-ui/src/components/common/CautionBox.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/DatePicker.vue 100.00% <ø> (+15.38%) ⬆️
.../src/components/common/DischargeConfirmSummary.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/ErrorContact.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/HomeLocationInfo.vue 100.00% <ø> (+92.85%) ⬆️
ppr-ui/src/components/common/InfoChip.vue 100.00% <ø> (+15.38%) ⬆️
ppr-ui/src/components/common/PidNumber.vue 100.00% <ø> (+89.55%) ⬆️
...-ui/src/components/common/RegistrationsWrapper.vue 100.00% <ø> (+40.78%) ⬆️
... and 143 more

... and 93 files with indirect coverage changes

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

1 similar comment
@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

doug-lovett
doug-lovett approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

dimak1
dimak1 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean work!

orelbn
orelbn approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@orelbn orelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

ppr-ui/src/components/collateral/generalCollateral/GenColAmend.vue Outdated
<tiptap-vuetify
v-if="false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No haha
thank you

Copy link
Collaborator Author

@cameron-eyds cameron-eyds Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in local commit, good eye 👍

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1395-bstohhlo.web.app

@cameron-eyds cameron-eyds merged commit 27c893a into bcgov:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orelbn orelbn orelbn approved these changes

@doug-lovett doug-lovett doug-lovett approved these changes

@dimak1 dimak1 dimak1 approved these changes

Assignees

@cameron-eyds cameron-eyds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cameron-eyds @pwei1018 @dimak1 @doug-lovett @orelbn