-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement business lookup #16918
Comments
I tagged this as P1 as it needs to be done sooner than later as it's blocking other tickets. |
@davemck513 @jdyck-fw @thorwolpert @doug-lovett While helping Kevin with this, I found a small hiccup: the Business Search API returns a 401 if there is JWT (auth token). However, Namerequest UI should function while a user is not logged in (no token). Thoughts on this? See also https://chat.developer.gov.bc.ca/channel/registries-auth?msg=8zZiDakvPC9tAn2Yi |
Kevin, do you remember what is needed to complete this ticket? |
I remember we need to update the API ( able to work without auth ) to test this PR. |
OK. As discussed in Standup this morning, let's proceed without the API update. (This feature still works but you must be logged in.) The API update is a separate ticket. |
Waiting on another PR to UXA this issue as per this comment in Github. |
@JazzarKarim Please create a new temp URL where we hope the Business Search API key will be populated. Thanks! |
@yuisotozaki Yui, please use this new link: https://namerequest-dev--pr-648-3ldflrwz.web.app Riyaz, You can also use the above link for testing. Thanks! |
Observation 1: When the "Change the name of an existing BC business" field value is chosen, the mouse cursor auto focuses on the "Business Name or Incorporation/Registration Number" field when the user's next step is to choose the jurisdiction. The business name lookup should not steal focus. Observation 2: When I select a business from the lookup popup list, the field disappears. The field should persist with the chosen business and enabled so that the user can search again. |
Re: observation 2 This was an implementation decision, since this ticket was only to create the business search component. Using it will be done in other tickets. It would have "corrupted" the implementation to have it persist the selected business and allow another search, so we didn't do that. You can refresh the page to search again. |
Is Observation 1 also an implementation dependent behaviour? That, when we implement the field in the context of where we want the lookup, we have control over the field focus? |
@JazzarKarim @kzdev420 With Sev away for a couple of days, would any of you be able to answer Yui's question above? Thank you! |
@yuisotozaki Yes Yui, we should have control over the field focus. I believe it was implemented this way here just for the sake of testing. |
Sounds good. Ready for QA! |
https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163039317
To do:
add business lookup component to first page
remove MRAS lookup from last page
move "Incorporation or Registration Number" on applicant-info-3.vue (existing MRAS/COLIN search) to beginning of misc flows (ie, add input to existing search page)we may actually need a different non-MRAS business searchbusiness lookup (same as other bus lookups - COLIN/SOLR search)
if existingfetchCorpNum()
function doesn't return business identifier and type, raise this ASAPExample (but look at other flow diagrams as well!):
The text was updated successfully, but these errors were encountered: