Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Restoration/Reinstatement NR flow #16640

Closed
9 of 16 tasks
severinbeauvais opened this issue Jun 2, 2023 · 13 comments
Closed
9 of 16 tasks

Update Restoration/Reinstatement NR flow #16640

severinbeauvais opened this issue Jun 2, 2023 · 13 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 2, 2023

TO DEVELOPER: SEE UI DESIGN FOR LATEST UXPIN, WHICH MAY SUPERSEDE THE REQUIREMENTS BELOW
Design: https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163925313/simulate/sitemap

  • action menu (already exists)
  • business lookup see Implement business lookup #16918
  • for BC company, prompt name/designation
  • For Coop and credit union, enter a name --> existing flow
  • for extrapro, prompt for jurisdiction ... see design for more
  • If Jurisdiction is Federal - Change text and put links for forms
  • button name should be Restore Business Now
  • create draft restoration filing and redirect to business dashboard (Filings UI)
  • Xpro with additional MRAS search
    • if the searched and selected business is xpro, and it is in a MRAS province, then perform a MRAS search to fetch the latest business info
  • If selected is business is not restorable - show error message "This business cannot be restored"

Everything in this section of the description needs to be cleaned up, as it's left over from the initial description:

  • progressive disclosure: show components only when they are needed
  • option to create a NR for restoration (existing flow)
    • is there a change to search for business id up front, or still on last page?
  • options to restore as a numbered company
    • blurb
    • new button to conditionally go to COLIN (use supported-restoration-entities FF in LauchDarkly)
  • option to restore an existing company
    • show button "Restore Now" (confirm in uxpin)
    • redirect user to business dashboard (not MBR)
    • link to restoration filing with NR pre-populated is future!
  • as above for NR view page (re: link to LEAR)
  • unit tests (verify restoration flows)
@severinbeauvais severinbeauvais added the ENTITY Business Team label Jun 2, 2023
@severinbeauvais severinbeauvais changed the title Update restoration flow Update Restoration flow Jun 13, 2023
@severinbeauvais severinbeauvais changed the title Update Restoration flow Update Restoration flow (aka Reinstatement) Jun 14, 2023
@severinbeauvais severinbeauvais changed the title Update Restoration flow (aka Reinstatement) Update Restoration flow (including Reinstatement) Jul 26, 2023
@severinbeauvais severinbeauvais changed the title Update Restoration flow (including Reinstatement) Update Restoration/Reinstatement flow Jul 26, 2023
@severinbeauvais severinbeauvais changed the title Update Restoration/Reinstatement flow Update Restoration/Reinstatement NR flow Aug 9, 2023
@JazzarKarim JazzarKarim self-assigned this Aug 23, 2023
@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Sep 6, 2023

Test / UX Assurance Notes

Please use this temporary URL for testing or UX assurance: https://namerequest-dev--pr-666-cq5bs87k.web.app/ https://namerequest-dev--pr-675-jao3khdh.web.app/

@JazzarKarim
Copy link
Collaborator

@yuisotozaki @janisrogers Please let me know if you can take a look, thanks a lot!

@yuisotozaki
Copy link

Observations:

  1. When firm registration numbers are entered, the UI returns a result but the "This business cannot be restored" message does not appear until the field loses focus. The error message should appear right after the business name is retrieved.
  2. If I try to pay for more than 1 NR in one session, the system throws an error about payment. Not sure if it's related to this ticket.
    Private Zenhub Image

@JazzarKarim
Copy link
Collaborator

Observations:

  1. When firm registration numbers are entered, the UI returns a result but the "This business cannot be restored" message does not appear until the field loses focus. The error message should appear right after the business name is retrieved.
  2. If I try to pay for more than 1 NR in one session, the system throws an error about payment. Not sure if it's related to this ticket.
    Private Zenhub Image

For question number 2, It's not related to my ticket. It might be worth creating a bug ticket for though.

As for question number 1, I'll fix that Yui!

@yuisotozaki
Copy link

Thanks Karim!

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Sep 7, 2023

@yuisotozaki Please test again using this URL Yui: https://namerequest-dev--pr-675-jao3khdh.web.app/
Thanks! I also fixed it for alterations when the user selects a business that cannot be altered. The same issue was there.

@yuisotozaki
Copy link

Looks good to me! Ready for QA.

@janisrogers
Copy link
Collaborator

I was just looking at the flow for reinstatement of a federal company and saw the following:
Private Zenhub Image

There should not be a button to go to corporate online (this is a paper filing) and the last three bullets should not show up.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Sep 11, 2023

Yes, there's a logic problem in the screenshot above, since it's showing 2 sets of bullets. It should only show the first.

Janis, could you please create a new ticket for this? (But it might be fixed collaterally by #17630 or #17468.)

@JazzarKarim
Copy link
Collaborator

Janis, I sent you a message on RC. I can't find this business that you selected. I've tried it for different XPRO businesses and it looks OK.

@janisrogers
Copy link
Collaborator

I was using the temporary link instead of the dev environment. The bullets look fine in dev, just need to remove the "Go to Corporate Online to Register" button.

@janisrogers
Copy link
Collaborator

I will open a bug ticket and assign it to you @JazzarKarim

@janisrogers
Copy link
Collaborator

bug ticket #17685 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants