Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear fields when request action type changes or when "Start Over" button clicked #17630

Closed
4 tasks done
riyazuddinsyed opened this issue Sep 6, 2023 · 4 comments
Closed
4 tasks done
Assignees
Labels
bug Something isn't working ENTITY Business Team Priority2 UX Assurance

Comments

@riyazuddinsyed
Copy link
Collaborator

riyazuddinsyed commented Sep 6, 2023

Describe the bug in the current situation

  • When the user selects "Combine two or more businesses" and then enters a name in the "Enter a name to request" field. Now in case the user selects another action say "Alter from one business type to another" then the "Enter a name to request" field prompts the old value

Steps to reproduce the behavior:

  1. Go to 'https://namerequest-dev--pr-666-cq5bs87k.web.app/'
  2. Click on 'Combine two or more Businesses'
  3. Enter a name in 'Enter a name to request'
  4. Now change the Action to 'Alter from one business type to another'
  5. Observe that the 'Enter a name to request' field prompts the old entered value
  • For Name Change NR flow, if I enter a value in the "Enter a name to request" field and pick a different business for which to create a name request, the field value retains the value. The "Enter a name to request" field content should be cleared with every new business lookup.
  • For Name Change NR flow, when the user visits the next screen and clicks on "Start Over" button, the fields on the first page do not get cleared. All fields should be cleared when "Start Over" button is pressed, including the state of the "I don't have a corporate number" checkbox state and its associated field, "Business's full legal name in home jurisdiction"
  • For Name Change NR flow, when expro is looked up, an international jurisdiction is chosen, "Business's full legal name in home jurisdiction" field is left blank, and "Check this name" button is pressed, the error message on the "Business's full legal name in home jurisdiction" field says, "Please enter a name to search for". This is incorrect as we do not search for international names. For this case, the error message should say, "Please enter the business's full legal name in home jurisdiction".
@riyazuddinsyed riyazuddinsyed added bug Something isn't working ENTITY Business Team labels Sep 6, 2023
@leodube-aot leodube-aot self-assigned this Sep 7, 2023
@leodube-aot leodube-aot changed the title Enter a name request field restoring the old input value Clear fields when request action type changes or when "Start Over" button clicked Sep 11, 2023
@leodube-aot
Copy link
Collaborator

@yuisotozaki @janisrogers : This ticket fixes the 4 bugs listed above. Temporary url: https://namerequest-dev--pr-680-q7ymjjkf.web.app

@yuisotozaki
Copy link

Observations:

  • The Action field and its dependent field do not seem to get reset with Start Over button press.
  • Confirmed all other fields are being reset.

@leodube-aot
Copy link
Collaborator

leodube-aot commented Sep 15, 2023

@yuisotozaki The action field and its dependent field should now get reset with Start Over button press. The changes have been merged into the refactoring feature branch, so please be aware there may be other bugs we are working through, and not all flows are working at the moment.

Temp url: https://namerequest-dev--pr-694-1jkkd4vv.web.app

@yuisotozaki
Copy link

Looks good to me! Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Priority2 UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants