Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namerequest UI - Validation message incorrect for new business and continuation in NRs #18159

Closed
janisrogers opened this issue Oct 13, 2023 · 5 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team UX Assurance

Comments

@janisrogers
Copy link
Collaborator

Describe the bug in current situation
When you select 'Check this Name' without entering a name in the input field, you receive the error message 'Please enter the business's full legal name in home jurisdiction' This message should say ' Please enter a name for the business'

This validation message should only show for extraprovincial name requests. I am seeing it with new requests and with continuation in.

Steps to Reproduce

  1. Choose to start a new BC-based business
  2. Choose Sole Proprietorship as the type
  3. Click on 'Check this Name' (without entering a name)
  4. See error

Expected behavior
This message should say ' Please enter a name for the business'

Screenshots/ Visual Reference/ Source

Private Zenhub Image

@janisrogers janisrogers added bug Something isn't working ENTITY Business Team labels Oct 13, 2023
@severinbeauvais severinbeauvais changed the title Name Request - Validation incorrect for empty sole proprietorship name Namerequest UI - Validation incorrect for empty sole proprietorship name Oct 13, 2023
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 13, 2023

The displayed message only applies to xpro flows (re: "home jurisdiction").

It should be a simpler message for the other flows.

@severinbeauvais severinbeauvais changed the title Namerequest UI - Validation incorrect for empty sole proprietorship name Namerequest UI - Validation message incorrect for new business and continuation in NRs Oct 13, 2023
@severinbeauvais severinbeauvais self-assigned this Oct 16, 2023
@severinbeauvais
Copy link
Collaborator

Test Notes

See sample screenshots in PR: bcgov/namerequest#729 (comment)

@severinbeauvais
Copy link
Collaborator

@janisrogers / @yuisotozaki :
The fix is temporarily deployed to https://namerequest-dev--pr-729-2j989mi5.web.app/ for you to perform UX Assurance.

@severinbeauvais
Copy link
Collaborator

The fix is now in Dev (and Test). @riyazuddinsyed , you can QA it any time.

@yuisotozaki
Copy link

Ready for QA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants