18159 Fixed name input error message for non-xpro #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
changed the title
Test ResultsNew named company: New sole proprietorship: New xpro in MRAS jurisdiction: New xpro in non-MRAS jurisdiction: |
- fixed Name Input error message logic
severinbeauvais
force-pushed
the
18159
branch
from
d77ef8c to
92784ce
Compare
severinbeauvais
commented
Oct 16, 2023
| } | ||
| return ['Please enter a name for the business'] | ||
| } |
There was a problem hiding this comment.
This is the same logic as for the label (lines 87-96 above).
I always wondered why this logic was different. The answer is that it was wrong 😆
severinbeauvais
commented
Oct 16, 2023
|
@ketaki-deodhar Please test a bunch of name change scenarios to verify that they all work. Thanks. |
severinbeauvais
force-pushed
the
18159
branch
from
4fa232d to
96de215
Compare
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-729-2j989mi5.web.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18159
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).