Filings UI - AGM Location filing (part II)

[Mihai-QuickSilverDev]

• Update Help content
• Verify AGM Year rules; update if needed
• Delete New AGM Location address component
• Add Reason text box up to 2,000 chars
• Add AGM Location text box up to 100 chars
• Add Completing Party shared component no longer needed
• Pre-populate the certify block when logged in user is not staff
• Add/update unit tests
  • Please fix unit test in EntityMenu.spec.vue which are skipped in previous PR

UI Design: https://preview.uxpin.com/c32b7a6fabe9dea89e09a5ae63323f485a02396c#/pages/164499138/simulate/sitemap
Please create several small PRs for the above.

Also:

• Update (if needed) "Request for AGM Location Change" in To Do (eg, in case payment fails) (even though it's $0)
  • simulate a pay error for a pending AGM Location Change filing in the To Do list. Refer 18027 AGM Location change business-filings-ui#551
  • show Change Payment Type? same as now
  • show Resume Payment? same as now
  • do not show Cancel Payment, as that will put the filing back into draft status, and we can't resume it
  • this means the user cannot delete the filing from the To Do list (Mihai is OK with this)
• Update (if needed) "Request for AGM Location Change" in Recent Filing History looks fine already - see comment below

[severinbeauvais]

Sample AGM Location Change in Recent Filing History:

[severinbeauvais]

@yuisotozaki @Mihai-QuickSilverDev @davemck513 Please see updated requirements above re: if payment fails (eg, invoice creation fails due to Pay API issue). Do you have any comments or questions?

[yuisotozaki]

I don't think the business sends any receipts today. So is it possible to bypass payment processing altogether? Do we really need a "no fee" receipt? @Mihai-QuickSilverDev

[Mihai-QuickSilverDev]

Currently, even for No Fee filings done by Staff, we invoke the Pay module and generate a zero charge receipt, with no exceptions. As probably the Business does not care about this, one way or another, Yui we look at you as one of the gatekeepers of unified user experience, to make the final decision. My vote is to invoke the Pay module and continue what we have done for every other filing.

[severinbeauvais]

I agree with Mihai. (Some staff filings don't have a receipt but they're special cases, and the fewer special cases the better.)

[ketaki-deodhar]

@JazzarKarim

Below are the observations from which can be completed in this ticket. Carryover from 18027
Could you please take a look at these/fix in this ticket?

Observations:

• Business not-in-good-standing is still allowed to select Request AGM Extension.
• Help expandable UI seems ... buggy; like it's not smooth animation when collapsing like all other filings' help.
• Cannot test the filing completion as the fields marked required cannot be entered just yet.

[JazzarKarim]

@Mihai-QuickSilverDev @severinbeauvais When payment fails for an AGM location change, shall I disable the cancel payment button (grey it out) or remove the dropdown menu all-together?

Keep in mind the above SC is not real data. This is dummy data that I created.

[Mihai-QuickSilverDev]

Yes, I think that having just the Resume payment option would make our lives easier. Since we do not have a salvable draft to resort to, that Cancel Payment would not do us any good.
@severinbeauvais @yuisotozaki Do you guys agree with this approach?

[severinbeauvais]

I agree. Remove the drop-down.

Is there still an option for "change payment option"? I don't know how that would help though. Maybe check with Argus on what kinds of pay errors we can see here.

[JazzarKarim]

Test Notes/UX Assurance

Please use https://business-filings-dev--pr-559-ku35gn15.web.app/ https://business-filings-dev--pr-564-dhq8toxr.web.app/ https://business-filings-dev--pr-567-7taa5hlg.web.app/ since currently the digital business credentials branch is in DEV.

[yuisotozaki]

Observations in temp-url:

• The legal name field is not auto-populated by the logged in non-staff user.
• Validation on the File Now button triggers error state highlight on fields that meet requirement. See attached screenshot below.

Private Zenhub Image

[JazzarKarim]

Observations in temp-url:

• The legal name field is not auto-populated by the logged in non-staff user.
• Validation on the File Now button triggers error state highlight on fields that meet requirement. See attached screenshot below.

@yuisotozaki Yui, sorry. Forgot to update the temp URL link. Please use: https://business-filings-dev--pr-564-dhq8toxr.web.app/
That should be the fix for the first one.

As for the second, I'll have a look!

[JazzarKarim]

@yuisotozaki Yui, please have a look in https://business-filings-dev--pr-567-7taa5hlg.web.app/
Both issues should be fixed now.

[yuisotozaki]

Thanks for the update - Ready for QA!