Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI - update dashboard (To do + Filings History List) #18274

Closed
3 tasks done
severinbeauvais opened this issue Oct 20, 2023 · 5 comments
Closed
3 tasks done

Filings UI - update dashboard (To do + Filings History List) #18274

severinbeauvais opened this issue Oct 20, 2023 · 5 comments
Assignees
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 20, 2023

  1. "Request for AGM Extension" in To Do list (ie, pending due to pay issue)
  1. "Request for AGM Extension" in Recent Filing History
  • see UI design
  • mock the data if needed (until filing shows up for real)
  • unit tests for both

UXPin: https://preview.uxpin.com/c32b7a6fabe9dea89e09a5ae63323f485a02396c#/pages/164122030/simulate/sitemap

@severinbeauvais severinbeauvais added the ENTITY Business Team label Oct 20, 2023
@severinbeauvais severinbeauvais changed the title Filings UI - update "Request for AGM Extension" in Recent Filing History Filings UI - update dashboard (To do + FHL) Oct 20, 2023
@jdyck-fw jdyck-fw changed the title Filings UI - update dashboard (To do + FHL) Filings UI - update dashboard (To do + Filings History List) Nov 1, 2023
@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Nov 1, 2023

Whomever picks this up can reach out to Karim for support for item 1 here if needed.

@severinbeauvais
Copy link
Collaborator Author

Test Notes

Verifying the AGM Extension item in the To Do list will be difficult since it's only there if there was an error creating the payment object (even though it's a $0 filing). But what you should see is only a "retry" action button (no dropdown with additional buttons).

Verifying the AGM Extension item in the Recent Filing History list will need to wait until we can file one of them. I used mocked data (which hopefully doesn't change) -- see PR for a screenshot.

@yuisotozaki
Copy link

Observations based on the screenshot in the PR.

  1. I forgot to update the name of the Recent Filing History item to just "AGM Extension" - sorry about that. Design updated. Please update implementation to "AGM Extension".

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 16, 2023

I forgot to update the name of the Recent Filing History item to just "AGM Extension" - sorry about that. Design updated. Please update implementation to "AGM Extension".

Actually, the display name for each ledger item comes from the Legal API. Ask Leo or Hongjing if they wouldn't mind adding this to 18370 or 18053 (though those are both in RFQA now). Or it could be added to one of the other BE tickets in the epic (which aren't assigned yet).

@yuisotozaki
Copy link

Let's move this ticket along and I'll cut a new ticket so we're not recirculating tickets.

This was referenced Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants