Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Unable to complete Transfer due to Sale/Gift due to validation errors #18289

Closed
3 tasks done
tlebedovich opened this issue Oct 23, 2023 · 9 comments
Closed
3 tasks done
Assignees
Labels
Assets bug Something isn't working UX Assurance

Comments

@tlebedovich
Copy link

tlebedovich commented Oct 23, 2023

in DEV

Staff/QS

  • WHEN I log in as Staff
    THEN open MHR 107833 (with a single Exec)
    THEN select transfer due to sale/gift
    AND add a new owner and fill out all of the required transfer details/declared value/doc id
    AND click Review and Confirm button
    THEN I receive an error saying you can't have mixed roles (which is correct because I never removed the original exec)
    BUT then when I remove the original exec (leaving just the new SO)
    THEN the error under the Review and Confirm button doesn't go away even though there are no errors remaining and the transfer is blocked.

Screen Shot 2023-10-23 at 1 55 02 PM

Screen Shot 2023-10-23 at 1 55 09 PM


  • Adding an owner to the Joint Tenant(s) with the Sale or Gift transfer type without groups stops user from navigating to the review screen:
    Steps to Reproduce:
  • Select an MH Registration which has Joint Tenant(s) (eg: 107835)
  • Select the Sale or gift transfer type
  • Add an owner without deleting the existing owners
  • Fill the Transfer details
  • Click on the Review & Confirm button
  • "< Please complete required information " validation is displayed without any error in the console

image


  • Added an owner to one of the Tenants in Common groups using Sale/Gift transfer without deleting an owner (107819)
  • filled in transfer details
  • clicked review and confirm
  • "< Please complete required information " validation is displayed

Screen Shot 2023-10-23 at 5 19 41 PM

Screen Shot 2023-10-23 at 5 29 09 PM

@tlebedovich tlebedovich added Assets bug Something isn't working UX Assurance labels Oct 23, 2023
@tlebedovich
Copy link
Author

tlebedovich commented Oct 23, 2023

@mstanton1 - new bug that would block a staff from doing a transfer - should this be added to staff release epic?

@chdivyareddy
Copy link
Collaborator

@tlebedovich @mstanton1 - added another scenario to the description, thanks!!

@tlebedovich tlebedovich changed the title Bug - Stopping Staff Transfer due to Sale/Gift Bug - Unable to complete Transfer due to Sale/Gift Oct 24, 2023
@tlebedovich tlebedovich changed the title Bug - Unable to complete Transfer due to Sale/Gift Bug - Unable to complete Transfer due to Sale/Gift due to validation errors Oct 24, 2023
@dimak1 dimak1 self-assigned this Oct 24, 2023
@dimak1
Copy link
Collaborator

dimak1 commented Oct 25, 2023

All issues were related and fixed! Just waiting for review and then merge. @tlebedovich

@dimak1
Copy link
Collaborator

dimak1 commented Oct 25, 2023

@dimak1
Copy link
Collaborator

dimak1 commented Oct 25, 2023

@tlebedovich this fix also resolves the issue for #18289. Since it's a very small fix that affects few tickets, I think I will just merge it to DEV?

@tlebedovich
Copy link
Author

ok. I can review this once its in dev if you can ping me when its ready in dev?

@dimak1
Copy link
Collaborator

dimak1 commented Oct 25, 2023

Merged to DEV.

@tlebedovich
Copy link
Author

@dimak1 - looks great thank you!

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

Scenario 1:

image

  • When the original executor is removed:
    image

image

Scenario 2:

image

image

Scenario 3:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants