Crown Charge Income Tax Act registration - General Collateral is required but entering Vehicle Collateral satisfies the edit in UI

[PatrickAHeath]

Describe the bug in current situation
This bug originated with OPS ticket 3186. Client was attempting to complete a Crown Charge Income Tax Act registration. The transaction indicates that General Collateral is required, but also allows Vehicle Collateral to be entered. When Vehicle Collateral is entered, the General Collateral item receives a green check mark and the UI edits pass. The transaction fails with no error message, as the API is requiring General Collateral text.

This may not be the only Crown Charge registration that this is happening in.

Requirements should be clarified first.

Link bug to the User Story

Impact of this bug
Clients satisfy the UI edits, but are then unable to complete the registration due to API edits not being in sync with the UI edits.

Chance of Occurring (high/medium/low/very low)
HIGH - when no General Collateral text is entered but Vehicle Collateral is entered.

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
PROD - begin Crown Charge Income Tax Act registration.

Steps to Reproduce
Steps to reproduce the behavior:

1. Begin Crown Charge Income Tax Act registration
2. When entering collateral, only enter Vehicle Collateral
3. Attempt to complete registration
4. See error

Actual/ observed behavior/ results
Transaction will error with no error message. General Collateral text is required by API edits.

Expected behavior
Transaction errors with error message displayed.
If General Collateral text is really required, UI entry and edit completion display properly

Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

[mstanton1]

Related to issue with default text not appearing 17491. The two tickets should be handled together.

[dimak1]

@mstanton1 just to clarify the intention here - we want to make the user add General Collateral for this reg type, and make Vehicle optional, therefore triggering an error if Gen Col is not entered. Is my understanding correct?

Looking at the code, it has not changed for almost two years. So I'm trying to double-check before I make any changes.

[mstanton1]

@dimak1 happy to clarify!

Specifically, with the Crown Charge Income Tax Act registration General Collateral is required. A client could provide optional vehicle collateral, but must include general collateral to complete the registration.

It was thought that this might be related to 17491 (we used to have pre-populated text for general collateral that stopped showing). In either case, the rule I've stated where general collateral must be entered, whether it's from something prepopulated or typed, is what we're implementing here while allowing vehicle collateral as optional:)

[dimak1]

@mstanton1 great, I appreciate the clarification, we are on the same page. Thanks!

[dimak1]

@mstanton1 if we are not fixing any other Registration type, then the following does not look right to me. For other registrations, adding just a vehicle collateral validates the step.

Private Zenhub Image

[mstanton1]

@dimak1 there are different rules for general collateral for different registration types. In some cases vehicle collateral is sufficient, and I would presume that is the case the with Crown Charge - Logging Tax Act shown above. @PatrickAHeath provided a spreadsheet that identifies whether default general collateral text should appear for each registration type in #17491 but it didn't seem to clearly identify the rule on which type of GC is required. @PatrickAHeath is there another requirements document confirming the rules for which type of general collateral, if any, is required for each registration type?

[dimak1]

@mstanton1 yes, makes sense. If General Collateral checkbox means both (Vehicle+Gen) then I'm good. Thanks!

[mstanton1]

@dimak1 yes, Collateral could be vehicle collateral or general collateral or both and the rules based upon registration type vary:) In this case the rule is that it must include general collateral (written in the free form box) in order for the check mark to appear for Crown Charge Income Tax Act registration. Vehicle collateral for this registration is optional and does not impact the checkbox / ability to proceed.

[PatrickAHeath]

@mstanton1 The Crown Charge registration functionality when initially implemented would have been from the spreadsheet. There were subsequent enhancements to modify the default GC text and addition of Vehicle Collateral - any documentation related to those changes is likely attached to the enhancement Zenhub tickets. (I believe that originated with Kevin and the work was completed after my move to OPS)

[chdivyareddy]

@dimak1 , the default GC text is not displayed in DEV for Income Tax Act. Can you please take a look, thanks!!

Private Zenhub Image

Expected:
Private Zenhub Image

[dimak1]

@chdivyareddy hmm, ok, looking into it.

[dimak1]

Fixed and merged to DEV @chdivyareddy

[chdivyareddy]

Verified in DEV for Income Tax Act when no Vehicle collateral is entered and default GC text is present.

Private Zenhub Image

Private Zenhub Image