Fix General Collateral Pre-fill

[dimak1]

Issue #: /bcgov/entity#18303

Description of changes:

• Fix switch/case statement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

[dimak1]

@cameron-eyds based on this fix, the switch/case in App.vue probably won't work either.

case (
          ErrorCodes.BCOL_ACCOUNT_CLOSED ||
          ErrorCodes.BCOL_USER_REVOKED ||
          ErrorCodes.BCOL_ACCOUNT_REVOKED ||
          ErrorCodes.BCOL_UNAVAILABLE
        ):

[codecov]

Codecov Report

Merging #1620 (668a796) into main (9255e77) will increase coverage by 4.89%.
Report is 323 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
+ Coverage   72.35%   77.24%   +4.89%     
==========================================
  Files         307      379      +72     
  Lines       12767     7017    -5750     
  Branches     2630     1122    -1508     
==========================================
- Hits         9237     5420    -3817     
+ Misses       3518     1565    -1953     
- Partials       12       32      +20     

Flag	Coverage Δ
pprui	77.24% <ø> (+4.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ppr-ui/src/App.vue	100.00% <ø> (+56.78%)	⬆️
ppr-ui/src/components/collateral/Collateral.vue	100.00% <ø> (+10.97%)	⬆️
...nents/collateral/generalCollateral/GenColAmend.vue	100.00% <ø> (+18.00%)	⬆️
...onents/collateral/generalCollateral/GenColEdit.vue	100.00% <ø> (+15.15%)	⬆️
...nts/collateral/generalCollateral/GenColSummary.vue	100.00% <ø> (+8.00%)	⬆️
...collateral/generalCollateral/GeneralCollateral.vue	100.00% <ø> (+6.66%)	⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue	100.00% <ø> (+22.58%)	⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue	100.00% <ø> (+19.41%)	⬆️
...cleCollateral/factories/useCollateralValidation.ts	71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts	70.14% <ø> (-0.91%)	⬇️
... and 34 more

... and 281 files with indirect coverage changes

[cameron-eyds]

Looks good!

[cameron-eyds]

ErrorCodes.BCOL_ACCOUNT_CLOSED

I've haven't bumped into this but your fix is definitely the way to fall-through cases, we can update handleErrorRegCreate() as well 👍