Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: show draft amalgamation #18534

Closed
11 tasks done
severinbeauvais opened this issue Nov 10, 2023 · 4 comments
Closed
11 tasks done

Filings UI: show draft amalgamation #18534

severinbeauvais opened this issue Nov 10, 2023 · 4 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 10, 2023

Same as an IA or registration, show draft amalgamation.

  • title should be " Amalgamation Application"
  • show NR details (same as IA)
  • verify action button label ("Fill out Amalgamation Application")
  • on action, redirect to Create UI to resume the draft
  • verify delete button label ("Delete Amalgamation Application")
  • verify can delete draft from action submenu
  • verify entity info header
  • verify recent filing history
  • verify office addresses
  • verify current directors
  • update unit tests
@jdyck-fw
Copy link
Collaborator

There's a backend ticket for legal api to create a business number. Which isn't implemented yet, so go into the DB look up an IA and change it to an amalgamation.

@severinbeauvais
Copy link
Collaborator Author

Test Notes

The "draft" label for Annual Reports was refactored. Sample URL:
https://dev.business.bcregistry.gov.bc.ca/CP0000840

The Entity header subtitle, Todo item name and Filing History item name for applications (ie, when using Txxx number) was refactored. Sample URLs:
https://dev.business.bcregistry.gov.bc.ca/Tc2caJYQrz (named amalgamation application)
https://dev.business.bcregistry.gov.bc.ca/T7HKt2pK2z (numbered amalgamation application)
https://dev.business.bcregistry.gov.bc.ca/T5OFJmMX4c (SP registration)
https://dev.business.bcregistry.gov.bc.ca/T3PWBu7r8A (GP registration)
https://dev.business.bcregistry.gov.bc.ca/Ty2i5TVeku (filed incorporation application)
https://dev.business.bcregistry.gov.bc.ca/TcDmkMbyD5 (filed SP registration)

@severinbeauvais
Copy link
Collaborator Author

@yuisotozaki You may begin assuring this in Dev. I still have to update some unit tests in this ticket before I move it along.

@yuisotozaki
Copy link

Observations:

  • Annual Report draft - Good
  • Named amalgamation application - Good
  • Numbered amalgamation application - Good
  • SP registration - Could not load
  • GP registration - Good
  • Filed incorporation application - Good
  • Filed SP registration - Good

The SP registration link resulted in a The name request has expired. error so I just made a new one.

Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants