Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: verify completed amalgamation filing in ledger (new TED business) #18807

Closed
severinbeauvais opened this issue Nov 29, 2023 · 11 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 29, 2023

The draft amalgamation filing displays in the bootstrap business -- same as IA.

Once the amalgamation is complete, the amalgamation filing displays in the new business (either using Temp reg number or BCxxx number) -- same as IA.

This ticket is to verify that the amalgation filing displays correctly in all cases (which was implemented in #18534).

@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 29, 2023
@severinbeauvais severinbeauvais changed the title Filings UI: verify completed amalgamation filing in ledger Filings UI: verify completed amalgamation filing in ledger (new TED business) Dec 13, 2023
@jdyck-fw jdyck-fw added monitor and removed monitor labels Dec 20, 2023
@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Jan 4, 2024

Filing crashes on submit, both Firefox and Google. Probably the Filer is not done yet?
@severinbeauvais What am I supposed to test?

image.png

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 4, 2024

Correct. The Filer is not yet complete, and there's possibly some Legal API work still needed.

However, the error you see above is a schema issue. Possibly this will be fixed in @JazzarKarim 's latest ticket - #18689.

This ticket was already in the current sprint, and I thought you were the most appropriate person to verify it, so I assigned you. But it's blocked at the moment.

@JazzarKarim
Copy link
Collaborator

Yup, this ticket cannot be verified as of right now Mihai. Just as Sev mentioned, the filer ticket and my ticket will have to be done before doing this.

@yuisotozaki
Copy link

Now that 18689 is complete, the filing completes successfully with businesses in Ready status.
Trying to access the TED company dashboard from MBR causes a 404 error.
image.png

@severinbeauvais
Copy link
Collaborator Author

@yuisotozaki I think you're the first one to try this! 🎉

@vysakh-menon-aot Thoughts?

@vysakh-menon-aot
Copy link
Collaborator

ah! The filing id 147393 (state_filing_id) is not belong to BC0871511. Its amalgamation filing id (BC0871523). This ticket should handle it https://app.zenhub.com/workspaces/entities-team-space---new-65550db1fcfd2f002838a52a/issues/gh/bcgov/entity/18978

@severinbeauvais
Copy link
Collaborator Author

Mihai, Yui, you are temporarily blocked from verifying this one until Vysakh completes 18978 (in progress).

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 12, 2024

Mihai, Yui, you can now verify this ticket.

Try this new TED: https://dev.business.bcregistry.gov.bc.ca/BC0871525?accountid=3040

(There's another ticket for the "Return to MBR" button in the expanded ledger item.)

PS Here's one of the TINGs for this amalgamation: https://dev.business.bcregistry.gov.bc.ca/BC0871491?accountid=2079

@severinbeauvais
Copy link
Collaborator Author

I have verified this ticket and it looks good to me. Mihai, Yui, any comments or can this ticket be moved to Done?

@yuisotozaki
Copy link

Looks good to me!

@Mihai-QuickSilverDev
Copy link
Collaborator

Looks good, work here completed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants