Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIN # - Additional Validations (Add a beneficial owner) #18554

Closed
gunanagar opened this issue Nov 14, 2023 · 3 comments
Closed

SIN # - Additional Validations (Add a beneficial owner) #18554

gunanagar opened this issue Nov 14, 2023 · 3 comments
Assignees
Labels
BTR Business Transparency Register Register BO

Comments

@gunanagar
Copy link
Collaborator

gunanagar commented Nov 14, 2023

This is enhancement story of UI: SIN/ITN and Tax Residency (Add a beneficial owner)

Implement validation as per linked design ticket.

@mstanton1
Copy link
Collaborator

@patrickpeinanw there are lots of comments in #17981 about the validation work for SIN. Can you advise on remaining work / why this ticket moved to icebox? I'm wondering if it's still needed.

Note: We have been advised by policy that because the client is currently going to be required to file what is in their internal transparency register (paper based) and there may be errors in that internal paper based register, we should not be preventing inputting information. If we have some level of validation on SIN we can leave it, but we will want to be mindful of the level of validation so we aren't preventing entry.

If it's easier to chat we can have a quick discussion early next week.

@patrickpeinanw
Copy link
Collaborator

@mstanton1 The comment in this ticket "SIN # shall be separated by a hyphen (-)" comes from the old design. The original idea was to store SIN numbers in "XXX-XXX-XXX" format.

Currently, The input box for SIN only accepts digit 0-9 and will save user input in this format: "XXX XXX XXX". When people enter tax numbers with hyphens, they will see the error: "The CRA tax number should not contain special characters". We need a UX design for this scenario. Options include:

  • Keep the error message, and hopefully users can figure out that they need to remove the hyphens.
  • Allow hyphens between every three digits, and keep the hyphens displayed until the 'DONE' button is clicked (when they come back to the form next time, it will still be displayed as "XXX XXX XXX")
  • Allow hyphens between every three digits, but remove the hyphens and just show "XXX XXX XXX" once the users finish typing.

@mstanton1
Copy link
Collaborator

Thanks for the clarity @patrickpeinanw . I've created a design ticket, linked this and the design ticket to the validation epic, and moved this into grooming for when design is ready. It's anticipated we will get to validation at the end of the next Program Increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register Register BO
Projects
None yet
Development

No branches or pull requests

4 participants