Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: SIN/ITN and Tax Residency (Add a beneficial owner) #17981

Closed
Apt766525 opened this issue Sep 27, 2023 · 12 comments
Closed

UI: SIN/ITN and Tax Residency (Add a beneficial owner) #17981

Apt766525 opened this issue Sep 27, 2023 · 12 comments
Assignees
Labels
BTR Business Transparency Register Register BO

Comments

@Apt766525
Copy link
Collaborator

Apt766525 commented Sep 27, 2023

Design Ticket
UI Design - SIN/ITN and Tax Residency (Add a beneficial owner) #17965

Two separate, unrelated groups (see details in wireframes):

  • CRA Tax Number as one input (SIN, ITN, or TTN)
  • Tax Residency

Instructions

SIN Validation: https://en.wikipedia.org/wiki/Social_insurance_number

Question for Policy: if we use SIN as unique, do we want to know it even if you pay tax in another country?
Answer = YES

General SIN info
https://www.tbs-sct.canada.ca/pol/doc-eng.aspx?id=13342

@Apt766525 Apt766525 added Register BO BTR Business Transparency Register labels Sep 27, 2023
@steveburtch
Copy link

Hey team! Please add your planning poker estimate with Zenhub @hfekete @kialj876 @patrickpeinanw

@steveburtch steveburtch changed the title UI: Tax Residency (Add a beneficial owner) UI: SIN/ITN and Tax Residency (Add a beneficial owner) Oct 24, 2023
@Apt766525
Copy link
Collaborator Author

@steveburtch @forgeuxGH5 Updated ticket with SIN / ITN Validation document

@gunanagar
Copy link
Collaborator

gunanagar commented Nov 13, 2023

This is fixed now. Thanks
@patrickpeinanw - Can you check this difference in text between design and actual UI.

Screen Shot 2023-11-13 at 11 39 50 AM

Screen Shot 2023-11-13 at 11 45 54 AM

@gunanagar
Copy link
Collaborator

gunanagar commented Nov 13, 2023

@patrickpeinanw SIN # shall be separated by a hyphen (-), but allowed here. Pls refer below

Screen Shot 2023-11-13 at 3 58 32 PM

@gunanagar
Copy link
Collaborator

gunanagar commented Nov 14, 2023

Should not accept 000 000 000 , Please check

Screen Shot 2023-11-14 at 10 19 13 AM

@gunanagar
Copy link
Collaborator

gunanagar commented Nov 14, 2023

This is will be fixed in later stories.

Highlighted mismatches between Figma wireframe and the application

  1. Display message is incorrect when CRA text field is not selected . Pls refer Figma design -
    https://www.figma.com/file/C2ThYIhZSO44dYBVGp8xAj/Register-Beneficial-Owners?type=design&node-id=1470-22&mode=design

2.Place holder text is not highlighted when CRA text field is selected
Screen Shot 2023-11-14 at 10 23 11 AM

@patrickpeinanw
Copy link
Collaborator

Should not accept 000 000 000 , Please check

Screen Shot 2023-11-14 at 10 19 13 AM

000 000 000 is supposed to pass the validation check. At the component level, we are only checking if the user input is a 9-digit string with acceptable combination.

Maybe this can be handled in the future when users submit the form and we can call some API to verify if the input is an actual tax number.

@forgeuxGH5
Copy link
Collaborator

@patrickpeinanw @gunanagar based on the SIN validation doc linked in the description a SIN can't start with 0 - is that not true?

@patrickpeinanw
Copy link
Collaborator

@patrickpeinanw @gunanagar based on the SIN validation doc linked in the description a SIN can't start with 0 - is that not true?

I need access to that google doc. A request has been sent.

For now, the only validation check is based on the Luhn Algorithm described in that wikipedia link. According to that link, tax numbers starting with 0 are CRA-assigned individual tax numbers, temporary tax numbers or adoption tax numbers.

@Apt766525
Copy link
Collaborator Author

@patrickpeinanw Shared access.

@patrickpeinanw
Copy link
Collaborator

@forgeuxGH5 @gunanagar Based on the google doc, I will:

  1. fail the validation if the first digit is 8
  2. fail the validation if "000 000 000" is entered, even if it can pass the checksum check.

Question: do we need to allow 0 to be the first digit? It might be a valid TTN?

@Apt766525
Copy link
Collaborator Author

@patrickpeinanw The rules are valid for TTN too. 0 cant be the first digit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register Register BO
Projects
None yet
Development

No branches or pull requests

6 participants