-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: SIN/ITN and Tax Residency (Add a beneficial owner) #17981
Comments
Hey team! Please add your planning poker estimate with Zenhub @hfekete @kialj876 @patrickpeinanw |
@steveburtch @forgeuxGH5 Updated ticket with SIN / ITN Validation document |
This is fixed now. Thanks |
@patrickpeinanw SIN # shall be separated by a hyphen (-), but allowed here. Pls refer below
|
This is will be fixed in later stories. Highlighted mismatches between Figma wireframe and the application
2.Place holder text is not highlighted when CRA text field is selected |
000 000 000 is supposed to pass the validation check. At the component level, we are only checking if the user input is a 9-digit string with acceptable combination. Maybe this can be handled in the future when users submit the form and we can call some API to verify if the input is an actual tax number. |
@patrickpeinanw @gunanagar based on the SIN validation doc linked in the description a SIN can't start with 0 - is that not true? |
I need access to that google doc. A request has been sent. For now, the only validation check is based on the Luhn Algorithm described in that wikipedia link. According to that link, tax numbers starting with 0 are CRA-assigned individual tax numbers, temporary tax numbers or adoption tax numbers. |
@patrickpeinanw Shared access. |
@forgeuxGH5 @gunanagar Based on the google doc, I will:
Question: do we need to allow 0 to be the first digit? It might be a valid TTN? |
@patrickpeinanw The rules are valid for TTN too. 0 cant be the first digit. |
Design Ticket
UI Design - SIN/ITN and Tax Residency (Add a beneficial owner) #17965
Two separate, unrelated groups (see details in wireframes):
Instructions
SIN Validation : Refer document for rules.
https://docs.google.com/document/d/11IxIqIIBg2bmSESIe2-RSHRZj4zmF1Sx/edit?usp=drive_link&ouid=100179527247507750986&rtpof=true&sd=true
SIN Validation: https://en.wikipedia.org/wiki/Social_insurance_number
Question for Policy: if we use SIN as unique, do we want to know it even if you pay tax in another country?
Answer = YES
General SIN info
https://www.tbs-sct.canada.ca/pol/doc-eng.aspx?id=13342
The text was updated successfully, but these errors were encountered: