Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: more framework changes, validation, etc (DO THIS LAST IN CREATE UI) #18689

Closed
10 of 11 tasks
severinbeauvais opened this issue Nov 21, 2023 · 10 comments
Closed
10 of 11 tasks
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 21, 2023

This is a follow-on ticket to #18536 (and also the general "do last" ticket to pull everything together).

To do

@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 21, 2023
@severinbeauvais severinbeauvais changed the title Create UI: more framework changes, validation, etc Create UI: more framework changes, validation, etc (DO THIS LAST IN CREATE UI) Nov 21, 2023
@severinbeauvais
Copy link
Collaborator Author

NOTE: this ticket is basically blocked by all other Create UI tickets.

@yuisotozaki
Copy link

yuisotozaki commented Jan 9, 2024

Blocked due to PayBC system not working. Unblocked. Resuming UXA.

@yuisotozaki
Copy link

yuisotozaki commented Jan 10, 2024

Observations on the overall filing experience:

  • When a not-in-good-standing business is added to the bus list and that business is made in-goos-standing, the business' status does not update on the amalgamation filing draft until the business is removed from the list and re-added. Reopening the draft/refreshing the page does not update the Status column. The status of the businesses in the list should update when the draft page is reloaded or the filing is re-opened.
  • Frozen business is appearing as "Ready" on the business list. We want to see Attention Required status with, "This business is frozen. Frozen businesses cannot be part of an amalgamation."
  • Historical business is showing up as Ready status in the business list.
  • Uncaught TypeError in console when loading draft image.png
  • Cannot get File and Pay to work possibly due to the type error above. image.png

Test Data:
Inc No. BC0871463, Phone: 1231231234 (historical)
Inc No. BC0871363, Phone: 1231231234 (frozen)
Inc No. BC 0871066, Phone: 1231231234

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 10, 2024

Yui, what account were you logged in with?

@severinbeauvais
Copy link
Collaborator Author

PS Can we create a new ticket to fix these things?

@yuisotozaki
Copy link

yuisotozaki commented Jan 10, 2024

Account: BCREG2014, 98902014
The Uncaught TypeError is caused by the business list issue. We can create a new ticket to address the business list issues.

@JazzarKarim
Copy link
Collaborator

OK, creating a ticket for that now. Thanks Yui.

@JazzarKarim
Copy link
Collaborator

New ticket: #19201

@yuisotozaki
Copy link

The File and Pay appears to be working. I'm observing additional things in addition to the above points. I'll raise the additional observations as bugs outside the scope of this ticket.
Ready for QA.

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Jan 10, 2024

@yuisotozaki Yui, can you please add those in the ticket I created above (if they're a part of the filing)? This'll keep everything in one place and can work on it in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants