Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal API: update TING validation rules VERIFY/IMPLEMENT #19154

Closed
4 of 5 tasks
severinbeauvais opened this issue Jan 5, 2024 · 5 comments
Closed
4 of 5 tasks

Legal API: update TING validation rules VERIFY/IMPLEMENT #19154

severinbeauvais opened this issue Jan 5, 2024 · 5 comments
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jan 5, 2024

Related to #19050.

TODOs

Also:

  • check for duplicate TINGs
  • check for at least 2 TINGs in the amalgamation
@severinbeauvais severinbeauvais added the ENTITY Business Team label Jan 5, 2024
@severinbeauvais
Copy link
Collaborator Author

@argush3 ^^ please

@argush3
Copy link
Collaborator

argush3 commented Jan 5, 2024

Updated TODOs

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 5, 2024

Thanks. I see the code change you propose blocks any paid/pending filing. I think we said this morning that only paid/pending dissolution filings should block an amalgamation. Can the BE code do that?

@argush3
Copy link
Collaborator

argush3 commented Jan 5, 2024

Thanks. I see the code change you propose blocks any paid/pending filing. I think we said this morning that only paid/pending dissolution filings should block an amalgamation. Can the BE code do that?

Allowable actions for the TING uses the following function to do this check.

Whoever implements this can use it as a starting point. Will update the TODO to include this info.

@severinbeauvais severinbeauvais changed the title Legal API: update TING validation rules Legal API: update TING validation rules VERIFY Jan 17, 2024
@severinbeauvais severinbeauvais changed the title Legal API: update TING validation rules VERIFY Legal API: update TING validation rules VERIFY/IMPLEMENT Jan 17, 2024
@chenhongjing chenhongjing self-assigned this Jan 19, 2024
@severinbeauvais
Copy link
Collaborator Author

Hongjing - please check with Vysakh on this one as he is already working in this area.

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

6 participants