19374 & 19375 amalgamation validaton fixes

[vysakh-menon-aot]

Issue #: /bcgov/entity#19374 and /bcgov/entity#19375

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[codecov]

Codecov Report

Attention: 256 lines in your changes are missing coverage. Please review.

Comparison is base (79511cd) 77.37% compared to head (d0d49eb) 76.76%.
Report is 71 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
- Coverage   77.37%   76.76%   -0.61%     
==========================================
  Files         202      168      -34     
  Lines       11602    10523    -1079     
  Branches     1961     1789     -172     
==========================================
- Hits         8977     8078     -899     
+ Misses       2043     1959      -84     
+ Partials      582      486      -96     

Flag	Coverage Δ
entityfiler	?
legalapi	76.76% <67.91%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
legal-api/src/legal_api/config.py	95.16% <100.00%> (+0.28%)	⬆️
legal-api/src/legal_api/core/filing.py	87.12% <100.00%> (+0.62%)	⬆️
legal-api/src/legal_api/core/filing_helper.py	50.00% <100.00%> (ø)
legal-api/src/legal_api/models/__init__.py	100.00% <100.00%> (ø)
...-api/src/legal_api/models/amalgamating_business.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/business.py	94.72% <100.00%> (+0.73%)	⬆️
legal-api/src/legal_api/models/dc_definition.py	90.69% <100.00%> (ø)
...l-api/src/legal_api/models/dc_revocation_reason.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/filing.py	92.41% <ø> (ø)
legal-api/src/legal_api/services/__init__.py	80.00% <100.00%> (ø)
... and 20 more

... and 43 files with indirect coverage changes

[sonarcloud]

Quality Gate failed

Failed conditions

17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[severinbeauvais]

LGTM