Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - A11Y - Add landmarks #21791

Closed
2 tasks done
saragunnarsson opened this issue Jun 13, 2024 · 9 comments
Closed
2 tasks done

UI - A11Y - Add landmarks #21791

saragunnarsson opened this issue Jun 13, 2024 · 9 comments

Comments

@saragunnarsson
Copy link
Collaborator

saragunnarsson commented Jun 13, 2024

Figma file here

  • Add landmarks marked up in figma
  • Add skip to main content link
@saragunnarsson
Copy link
Collaborator Author

@saragunnarsson saragunnarsson changed the title UI - Add landmarks UI - A11Y - Add landmarks Jun 13, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jul 9, 2024

@LizGovier Would like to confirm page structure/landmarks.

There is another component that is not mentioned in the Figma - System Banner. Currently it's located in <main>. After we update the structure to move Breadcrumbs above the <main> into <nav>, the system banner would be between <header> and <nav>. Is that ok?

Screenshot 2024-07-09 at 08.49.51.png

@dimak1
Copy link
Collaborator

dimak1 commented Jul 9, 2024

@dimak1 dimak1 assigned LizGovier and unassigned dimak1 Jul 9, 2024
@LizGovier
Copy link
Collaborator

Hey @dimak1
I'm just looking at the landmarks and there seems to be 2 navigation tags, The second one goes straight to the bottom. (Note: using SkipTo chrome extension)
Screen Shot 2024-07-10 at 12.57.22 PM.png

cc @arlentees I wouldn't mind enhancing this landmark feature to show more landmark sections with section title. Will also reach out to Alexis regarding this. Example from W3.org:
Screen Shot 2024-07-10 at 12.58.05 PM.png

@dimak1
Copy link
Collaborator

dimak1 commented Jul 10, 2024

@LizGovier There are indeed two Navigation tags. Using WAVE extension I can see one for Top Nav, and the other is for Footer. Please let me know if you want to make any updates.

@LizGovier
Copy link
Collaborator

Thanks @dimak1
Using the 'WAVE' chrome extension, I verified the MHR/PPR Dashboard and an MHR Registration page. Both showed the proper landmarks that Sara provided. This is RFQA

Screen Shot 2024-07-11 at 11.53.12 AM.png

Screen Shot 2024-07-11 at 11.55.25 AM.png

@LizGovier LizGovier assigned dimak1 and unassigned LizGovier Jul 11, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jul 11, 2024

Thanks @LizGovier! For RFQA, you can also assign it directly to Divya and put it in the RFQA column.

@dimak1 dimak1 assigned chdivyareddy and unassigned dimak1 Jul 11, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jul 15, 2024

Had to sync with main and resolve some conflicts. Should be available in DEV now. Thanks!

@chdivyareddy
Copy link
Collaborator

Verified in TEST!

image.png

image.png

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants