Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - A11Y - Add focus state styling (BC Reg Header) #22147

Closed
LizGovier opened this issue Jul 4, 2024 · 7 comments
Closed

UI - A11Y - Add focus state styling (BC Reg Header) #22147

LizGovier opened this issue Jul 4, 2024 · 7 comments
Assignees
Labels

Comments

@LizGovier
Copy link
Collaborator

LizGovier commented Jul 4, 2024

4.0 SBC Common Component

  • Add border style to anything focused via a tab in SBC Header

Main Keyboard Actions:
Tab: Move forward through all interactive elements
Shift + Tab: Go backwards to a previous interactive element
Enter: Select or activate an interactive element
Spacebar: To expand a drop-down menu, or select a radio button.
Up and down arrows: To scroll through a page, or open/navigate through options in a drop-down menu.
Esc: to exit a dropdown, dialog box or modal

See Figma Design for details

Screen Shot 2024-07-04 at 11.08.24 AM.png

Note: 'Skip to Main Content' is covered in ticket #21791 (Landmarks)

@LizGovier
Copy link
Collaborator Author

@dimak1
Copy link
Collaborator

dimak1 commented Jul 16, 2024

This ticket is pending screenshare with @LizGovier.

@dimak1
Copy link
Collaborator

dimak1 commented Jul 17, 2024

@seeker25 PR is open and ready for review.

@dimak1
Copy link
Collaborator

dimak1 commented Jul 19, 2024

Ready in DEV.

@dimak1 dimak1 assigned chdivyareddy and unassigned dimak1 and seeker25 Jul 19, 2024
@chdivyareddy
Copy link
Collaborator

Hey @dimak1 , all the header functionality is working as expected, but the MHR search dropdown options are not functioning when the down arrow or tab buttons are used to navigate through the MHR search options. Please take a look at the screen recording from Chrome browser or you can try in DEV env, thank you!!

Private Zenhub Video

@chdivyareddy chdivyareddy assigned dimak1 and unassigned chdivyareddy Jul 19, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jul 22, 2024

Hi @chdivyareddy, appreciate thorough testing, but the MHR Search dropdown is not part of this ticket. This is just a Header related work.
I see in the video that the MHR Search dropdown is losing focus. There might be more work to be done besides just styling and it could be its own ticket or combined with other items that also lose focus.
That's my opinion, please let me know what you think. Thanks

@chdivyareddy
Copy link
Collaborator

@dimak1 , thanks for your input, will create a new ticket for this issue and move the current ticket along:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants