Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal API: postpone NR expiry in future-effective continuation application - VERIFY #22092

Closed
severinbeauvais opened this issue Jul 2, 2024 · 11 comments
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 2, 2024

This code already exists but I'm not sure that it supports FE continuation in (or all other) applications. We might also consider leveraging this code so that an application-under-review's NR doesn't expire. will be business process

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jul 2, 2024
@severinbeauvais
Copy link
Collaborator Author

@vysakh-menon-aot Can you please add a description of what needs to be updated to support FE continuation in (or other) applications/NRs? Thanks.

@vysakh-menon-aot
Copy link
Collaborator

It should be working for continuation in. Current implementation postpone expiry of NR for the below FE filings

  • AMALGAMATIONAPPLICATION
  • CONTINUATIONIN
  • INCORPORATIONAPPLICATION
  • REGISTRATION

@severinbeauvais severinbeauvais changed the title Legal API: postpone expiry of future-effective NR Legal API: postpone expiry of future-effective NR - VERIFY Jul 2, 2024
@severinbeauvais severinbeauvais self-assigned this Aug 27, 2024
@severinbeauvais
Copy link
Collaborator Author

I will verify this.

@severinbeauvais severinbeauvais changed the title Legal API: postpone expiry of future-effective NR - VERIFY Legal API: postpone NR expiry in future-effective continuation application - VERIFY Aug 28, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Aug 29, 2024

To verify this, first I created a NR, approved it, and set the expiry date to today (Aug 29):

image.png

Then I submitted a continuation application with a future effective date of tomorrow (Aug 30) at 8:30 am:

image.png

Then I reviewed and approved the continuation authorization:

image.png

Now I will wait until tomorrow to see if the NR expiry date was extended until past the FE date.

Ref:
https://dev.business.bcregistry.gov.bc.ca/Tf1sYWOo84?filing_id=150718&accountid=3040
https://dev.namex.bcregistry.gov.bc.ca/examine?nr=3125325

@vysakh-menon-aot
Copy link
Collaborator

Approval process has noting to do with NR expiry extension. It would have extended when user resubmited with a FE date

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Aug 30, 2024

Test Results

It appears that the NRs are being automatically expired as usual on their expiry date (but there is no record of this because expiry doesn't generate a transaction - see #23059).

It also appears that the IA / continuation-in above were successfully filed/completed, even though the NR was probably expired. This is likely because of bug #22931 (which handles the NR consumption).

This ticket needs to be tested again once 22931 is fixed. see other tests below

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Sep 4, 2024

Test Results # 2

  1. I created the following NRs, then approved them and changed them to expire today (Sept 4):
    https://dev.namex.bcregistry.gov.bc.ca/examine?nr=1661599 (SEVERIN FUTURE EFFECTIVE IA LTD.)
    https://dev.namex.bcregistry.gov.bc.ca/examine?nr=4480303 (SEVERIN FUTURE EFFECTIVE CONT IN LTD.)
  2. I filed an IA and a Continuation In using the above NRs and set them to be effective tomorrow (Sept 5) at 12:00pm Pacific. (I also approved the cont in authorization review.)
    https://dev.business.bcregistry.gov.bc.ca/TtCcs7MhBe?filing_id=150795&accountid=3040 (IA)
    https://dev.business.bcregistry.gov.bc.ca/Tn6ZZ1U11n?filing_id=150796&accountid=3040 (Cont In)
  3. I checked Namex and both NRs still show as expiring today (Sept 4) instead of being extended to the expiry date + 1 = Sept 6. (*)
  4. Now we wait until tomorrow to see if the IA/Cont In are successfully completed by the Filer.
  5. Also we wait to see if the NRs are successfully set to Consumed.

Overall, this ticket is still blocked by other bugs (#23050) and testing cannot be completed.

Summary: in this test, as some code was not yet fixed, the NRs show as Expired instead of Consumed.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Sep 6, 2024

Test Results # 3

Apparently, #23050 is now fixed, so I'm trying again...

  1. I created the following NRs, then approved them and changed them to expire today (Sep 6):
    SEVERIN FUTURE EFFECTIVE IA NO. 2 (https://dev.namex.bcregistry.gov.bc.ca/examine?nr=9201513)
    SEVERIN FUTURE EFFECTIVE CONT IN NO. 2 LTD. (https://dev.namex.bcregistry.gov.bc.ca/examine?nr=3250039)
  2. I filed an IA and a Continuation In using the above NRs and set them to be effective Monday (Sept 9) at 10:00pm Pacific. (I also approved the cont in authorization review.)
    https://dev.create.business.bcregistry.gov.bc.ca/incorporation-define-company?id=TD53NBFWkC&accountid=3040 (IA)
    https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TqKrP7NPct&accountid=3040 (Cont In)

Blocked on Namex error. Eve is investigating.

  1. Today (Sept 9) I was able to set both NR expiry dates to today (11:59pm).
  2. Today I filed both applications with a FED of tomorrow (Sept 10). Tomorrow we will see what happened to the filings and NRs.
  3. I checked the NRs, and both had their expiry date deferred by 2 days (ie, 1 past the application FED), as expected!

Summary: both NRs show as Consumed, as expected!

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Sep 6, 2024

Test Results # 4

There's a Namex error in Dev so I'm now trying in Test...

  1. I created the following NRs, then approved them and changed them to expire today (Sep 6):
    SEVERIN FUTURE EFFECTIVE IA LTD. (https://test.namex.bcregistry.gov.bc.ca/examine?nr=7275893)
    SEVERIN FUTURE EFFECTIVE CONT IN LTD. (https://test.namex.bcregistry.gov.bc.ca/examine?nr=7443844)
  2. I filed an IA and a Continuation In using the above NRs and set them to be effective Monday (Sept 9) at 10:00pm Pacific. (I also approved the cont in authorization review.)
    https://test.create.business.bcregistry.gov.bc.ca/incorporation-define-company?id=TvPzZaO2wg&accountid=1999 (IA)
    https://test.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=T4SeDfAWR7&accountid=1999 (Cont In)

Blocked on Namex error. Eve is investigating.

  1. Today (Sept 9) I was able to set both NR expiry dates to today (11:59pm).
  2. Today I filed both applications with a FED of tomorrow (Sept 10). Tomorrow we will see what happened to the filings and NRs.
  3. I checked the NRs, and both had their expiry date deferred by 2 days (ie, 1 past the application FED), as expected!

Summary: both NRs show as Consumed, as expected!

@severinbeauvais
Copy link
Collaborator Author

This ticket is now verified.

Still to verify: whether the NR is changed to Consumed when the applications are completed by the Filer (which will happen tomorrow at 9am). See also #23050.

@severinbeauvais
Copy link
Collaborator Author

I have verified, in Dev and Test, that the NRs have been changed to Consumed status (along with a Consumed By business id).

This completes the verification of this ticket.

cc: @eve-git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.
Projects
None yet
Development

No branches or pull requests

4 participants