NR expiry date is not being extended for future effective filings

[severinbeauvais]

This used to work, but I've been testing with a FE continuation application and a FE incorporation application and it's not working right now.

This may be caused by #22931. apparently not

Example:

I created this NR, approved it, and set it to expire today (Aug 29 at 11:59 PM):

https://dev.namex.bcregistry.gov.bc.ca/transactions?nr=2516555

Then I filed this IA with a future effective date of tomorrow (Aug 30) at 7:30 AM:

https://dev.business.bcregistry.gov.bc.ca/T05aKXLl70?filing_id=150720&accountid=3040

My expectation is that the NR's expiry date would be extended to the FE date plus 1 extra day buffer. In this case, the new expiry date should be Aug 31 (at 11:59 PM). But I see no evidence of that.

PS The original ticket to extend the NR expiry is #3883.

[severinbeauvais]

I have tested this scenario with an incorporation application and the results were the same (no evidence that the NR expiry was extended).

In other words, this bug likely applies to IAs, registrations, amalgamations and continuation-ins.

As such, I think the priority is higher than 3. What do you think? @vysakh-menon-aot @ozamani9gh @davemck513 @Mihai-QuickSilverDev

[severinbeauvais]

I tested this again today, and again the NR expiry was not extended as expected. @vysakh-menon-aot looked into it and believes something got changed in Namex API:

@ozamani9gh , @rarmitag , @eve-git , can you look into this? The impact is that the Entity Filer may not be able to mark a NR as Consumed -- the NR will already be Expired and we don't know if Namex allows consuming an expired NR. But we believe this will not stop a business from being incorporated with the correct approved name.

[eve-git]

I am reviewing the code change.
https://github.com/bcgov/namex/pull/1557/files#diff-568c1126b23759b7e43e19f04dc1c911ddc673039bec483f27394af5be5a454a

[Mihai-QuickSilverDev]

@ozamani9gh @eve-git The NR upgrade to Priority appears to be broken. This is now a high priority.

[eve-git]

Ready to test in TEST environment

Besides the test case for incorporation (as described), please also include the test cases mentioned in #22243.

[severinbeauvais]

@eve-git Can this be tested in Dev environment?

[severinbeauvais]

I have verified, in both Test and Dev, that the NR expiry date is extended to "1 day past the application's future effective date), as expected.

Still to verify: whether the NR is changed to Consumed when the applications are completed by the Filer (which will happen tomorrow at 9am). Verified! Here's the data from a previous test I did:

[severinbeauvais]

We moved this to Done in Entities-Olga's board because, as far as we're concerned, this is fixed.

We did not close this ticket because Names team needs to test/release/deploy it.

[Mihai-QuickSilverDev]

• Tested. Moving to Ready for Release.

[Mihai-QuickSilverDev]

@ozamani9gh Would it be okay to close this ticket in the Entities space? Would it be captured okay in the Names space?

[ozamani9gh]

once you close it, then it closes the ticket on our board as well, leave it in done for their board, till we release it

[vikas-gov]

Release date to be confirmed.