Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Request UI - update jurisdiction to match CPROD. #22425

Closed
ozamani9gh opened this issue Jul 24, 2024 · 7 comments
Closed

Name Request UI - update jurisdiction to match CPROD. #22425

ozamani9gh opened this issue Jul 24, 2024 · 7 comments
Assignees
Labels
Name Request Names Team Name Request Name Examination Team Priority1

Comments

@ozamani9gh
Copy link
Collaborator

ozamani9gh commented Jul 24, 2024

From David Roberts

I have changed the two single quotes to one single quote in COLIN. The following now needs to be done at https://github.com/bcgov/namerequest/blob/main/src/list-data/intl-jurisdictions.ts

POSTGRES: Turkey has two dots (umlaut) over the letter u for short_desc and full_desc
POSTGRES: VI (Virgin Islands, U.S. ) short_desc should be truncated to 15 - all other countries have been truncated to 15
POSTGRES: VG (Virgin Islands, British) short_desc should be truncated to 15 - all other countries have been truncated to 15

country_type in POSTGRES but not COLIN

no rows selected

country_type in COLIN but not POSTGRES

CO SHORT_DESC FULL_DESC CPRD_ADDRESS_COUNT CPRD_JURISDICTION_COUNT


CD CONGO, THE DEMO CONGO, THE DEMOCRATIC REPUBLIC OF THE 68 1
FX FRANCE, METROPO FRANCE, METROPOLITAN 2 0

country_type.short_desc

CO COLIN POSTGRES CPRD_ADDRESS_COUNT CPRD_JURISDICTION_COUNT


FM MICRONESIA, FED Micronesia 2 0
KP KOREA, DEMOCRAT Korea 163 0
KR KOREA, REPUBLIC Korea 3265 63
MD MOLDOVA, REPUBL Moldova 17 0
MK MACEDONIA, THE Macedonia 10 0
TR TURKEY Turkiye 543 4
TZ TANZANIA, UNITE Tanzania 86 2

country_type.full_desc

CO COLIN POSTGRES CPRD_ADDRESS_COUNT CPRD_JURISDICTION_COUNT


BQ BONAIRE, ST EUSTATIUS AND SABA Bonaire 0 0
FM MICRONESIA, FEDERATED STATES OF Micronesia 2 0
KP KOREA, DEMOCRATIC PEOPLE'S REPUBLIC OF Democratic People's Republic Of Korea 163 0
KR KOREA, REPUBLIC OF South Korea 3265 63
MD MOLDOVA, REPUBLIC OF Moldova 17 0
MK MACEDONIA, THE FORMER YUGOSLAV REPUBLIC Macedonia 10 0
PS PALESTINIAN TERRITORY, OCCUPIED Palestinian Territory 7 0
TR TURKEY Turkiye, Republic Of 543 4
TZ TANZANIA, UNITED REPUBLIC OF Tanzania 86 2

@ozamani9gh ozamani9gh added Names Team Name Request Name Examination Team Priority1 labels Jul 24, 2024
@ozamani9gh
Copy link
Collaborator Author

list of jurisdiction.txt

@hanlunBCRegistries
Copy link
Collaborator

besides update jurisdiction, do we have to add other two countries that are missing in the POSTGRES as mentioned aboveimage.png

@hanlunBCRegistries
Copy link
Collaborator

PR created

@hanlunBCRegistries
Copy link
Collaborator

Added new jurisdictions:
CD: SHORT_DESC: "CONGO, THE DEMO", FULL_DESC: "CONGO, THE DEMOCRATIC REPUBLIC OF THE"
FX: SHORT_DESC: "FRANCE, METROPO", FULL_DESC: "FRANCE, METROPOLITAN"
Truncated SHORT_DESC for:
VI: "Virgin Islands, U.S." to "USVI"
VG: "Virgin Islands, British" to "BVI"

@Mihai-QuickSilverDev
Copy link
Collaborator

This NR 2776145 is using Turkiye. It fails on the first screen in COLIN, the registration cannot continue. Same like before. We need to review more. This failed.
@ozamani9gh

@hanlunBCRegistries
Copy link
Collaborator

NEW PR created @Mihai-QuickSilverDev @ozamani9gh :
Updated various jurisdiction names and descriptions to match the latest standards and requirements:
Bonaire updated text to "BONAIRE, ST EUSTATIUS AND SABA".
Korea (North) updated short description to "Korea, Democrat" and text to "Korea, Democratic People's Republic of".
Korea (South) updated short description to "Korea, Republic" and text to "Korea, Republic of".
Macedonia updated short description to "THE Macedonia" and text to "Macedonia, The Former Yugoslav Republic".
Micronesia updated short description to "Micronesia, FED" and text to "Micronesia, Federated States of".
Moldova updated short description to "REPUBL Moldova" and text to "Moldova, Republic of".
Palestinian Territory updated text to "Palestinian Territory, OCCUPIED".
Tanzania updated short description to "Unite Tanzania".
Turkey updated short description to "Turkey" and text to "Turkey, Republic Of".

@Mihai-QuickSilverDev
Copy link
Collaborator

  • This work was validated with David Roberts. Ready for Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Name Request Names Team Name Request Name Examination Team Priority1
Projects
None yet
Development

No branches or pull requests

3 participants