Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22425-feat: Update jurisdiction list and truncate short descriptions #773

Conversation

hanlunBCRegistries
Copy link
Collaborator

@hanlunBCRegistries hanlunBCRegistries commented Aug 12, 2024

Issue #: /bcgov/entity#22425

Description of changes:

  • Added new jurisdictions:
    • CD: SHORT_DESC: "CONGO, THE DEMO", FULL_DESC: "CONGO, THE DEMOCRATIC REPUBLIC OF THE"
    • FX: SHORT_DESC: "FRANCE, METROPO", FULL_DESC: "FRANCE, METROPOLITAN"
  • Truncated SHORT_DESC for:
    • VI: "Virgin Islands, U.S." to "USVI"
    • VG: "Virgin Islands, British" to "BVI"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@EPortman
Copy link
Collaborator

/gcbrun

@EPortman
Copy link
Collaborator

@hanlunBCRegistries version number.

@hanlunBCRegistries
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-773-36529cdy.web.app

@hanlunBCRegistries
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-773-36529cdy.web.app

Copy link
Collaborator

@EPortman EPortman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@hanlunBCRegistries hanlunBCRegistries merged commit 462ac23 into bcgov:main Aug 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants