This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Search MVP in one commit #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklise
approved these changes
May 9, 2017
| resolve({data: data, count: c}); | ||
| } | ||
| }); | ||
| } else { | ||
| // console.log('search.error = ' + JSON.stringify(error)); | ||
| console.log('search.error = ' + JSON.stringify(error)); |
| // return the paginated results with the total count | ||
| resolve({data: sorted, count: cnt}); | ||
| } else { | ||
| console.log('search.error = ' + JSON.stringify(error)); |
| var name = req.query.collection; | ||
| var Dbclass; | ||
| var fields; | ||
| switch(name) { |
There was a problem hiding this comment.
Declare Dbclass at the top.
Remove the switch statement, turn it into an IF.
Reject if the name != 'documents'
| return model.search (searchFields, queryOptions); | ||
| } | ||
| setSessionContext (req) | ||
| .then (function (opts) { |
| for (var key in options.filterByFields) { | ||
| if (options.filterByFields.hasOwnProperty(key)) { | ||
| filter[key] = options.filterByFields[key]; | ||
| console.log(filter); |
| @@ -1,10 +1,20 @@ | |||
| 'use strict'; | |||
|
|
|||
| module.exports = function (app) { | |||
| // Root routing | |||
| var core = require('../controllers/core.server.controller'); | |||
| var path = require('path'); | |||
There was a problem hiding this comment.
A mix of spaces and tabs between vars and "="
| <a ng-if="infoPanel.data.userCan.read" | ||
| class="btn btn-sm btn-default" | ||
| href="/api/document/{{ infoPanel.data._id }}/fetch" | ||
| target="_self" |
| controllerAs: 'instruct', | ||
| size: 'lg' | ||
| }); | ||
| modalInstructions.result.then(function (data) { |
There was a problem hiding this comment.
What's the purpose of this?
|
ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by deleting my fork. Recreate fork. Take a directory with all the code and remove the .git references. Copy over the new fork. Then carefully determine what is in and not in.