This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Epic 1070 #156
Merged
Epic 1070 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklise
approved these changes
Jun 8, 2017
There was a problem hiding this comment.
Makes sense to me, provided that the node.model object is in fact the most recent version of the directoryStructure (it should reflect what /api/project/:project/directory/list returns). I say this because it's possible to manipulate the client side structure without persisting the model to the back-end. This bug looks to have happened because of the client code not updating the directoryStructure object in the event of a change to the structure.
|
I think we should remove scope.project.directoryStructure or else put a big comment in the code to say this object does not get updated when changes are made to the underlying directory structure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marklise the reason I changed $scope.project.directoryStructure to scope.node.model is because scope.project.directoryStructure does not get updated with newly created folders. But scope.model.node gets updated with the new folder in it. I can see data duplication staying in the scope (i.e $scope.project.directoryStructure and scope.node.model holds the same data). Please let me know if you have any concerns about this issue.