Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-config produces invalid configuration - DraftDataset with blank org #127

Open
rustyjux opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working jira

Comments

@rustyjux
Copy link

rustyjux commented Nov 6, 2024

Description

When using gwa generate-config interactively, if org/orgunit are left blank, then they are blank in the created DraftDataset and validation fails when publishing.

organization: 
organizationUnit:

Meanwhile, if parameters are provided (e.g.
gwa generate-config --template quick-start --service <MYSERVICE> --upstream https://httpbin.org) then org/orgunit are autofilled with:

organization: ministry-of-citizens-services
organizationUnit: databc

org and orgunit are optional fields (ie you can omit those fields and still add/update a dataset), but they cannot be blank.

Acceptance criteria

  • review the default behaviour for org/orgunit.
    • Interactive and template use should behave the same (use same defaults, never leave blank fields in yaml)
    • Possible approaches include:
      • provide default values (CITZ/databc) to interactive, hit ENTER to accept
      • OR do not have default values, publish dataset without org/orgunit if not provided
  • always produce valid output from generate-config
    • do not create DraftDataset where organization and organizationUnit are blank which will fail validation
@rustyjux rustyjux added bug Something isn't working jira labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira
Projects
None yet
Development

No branches or pull requests

1 participant