Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17348 - Change SR correction to be consistent with other correction filings #2178

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

Jxio
Copy link
Collaborator

@Jxio Jxio commented Aug 21, 2023

Issue #: /bcgov/entity17348

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@Jxio Jxio self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2178 (1a8d35b) into main (53b46e4) will decrease coverage by 0.40%.
Report is 26 commits behind head on main.
The diff coverage is 50.29%.

@@            Coverage Diff             @@
##             main    #2178      +/-   ##
==========================================
- Coverage   77.16%   76.77%   -0.40%     
==========================================
  Files         222      224       +2     
  Lines       12759    12845      +86     
  Branches     2126     2150      +24     
==========================================
+ Hits         9846     9862      +16     
- Misses       2272     2334      +62     
- Partials      641      649       +8     
Flag Coverage Δ
entityemailer 71.88% <64.10%> (-0.29%) ⬇️
legalapi 76.89% <46.21%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ailer/email_processors/dissolution_notification.py 48.14% <0.00%> (-0.45%) ⬇️
...r/src/entity_filer/filing_processors/alteration.py 92.00% <ø> (-0.31%) ⬇️
...r/src/entity_filer/filing_processors/correction.py 92.30% <ø> (-2.57%) ⬇️
.../src/entity_filer/filing_processors/dissolution.py 80.35% <ø> (-0.35%) ⬇️
.../filing_processors/filing_components/correction.py 96.77% <ø> (+0.62%) ⬆️
...ocessors/filing_components/rules_and_memorandum.py 86.66% <ø> (-0.84%) ⬇️
...ty_filer/filing_processors/incorporation_filing.py 77.41% <ø> (-0.48%) ⬇️
...ue_services/entity-filer/src/entity_filer/utils.py 100.00% <ø> (ø)
..._services/entity-filer/src/entity_filer/version.py 100.00% <ø> (ø)
legal-api/src/legal_api/reports/report.py 26.54% <15.25%> (-0.98%) ⬇️
... and 16 more

@Jxio Jxio requested review from seeker25 and vysakh-menon-aot and removed request for seeker25 and vysakh-menon-aot August 21, 2023 23:33
@seeker25 seeker25 changed the title 17348 - Remain sr correction consistent with Entities correction filing 17348 - Change SR correction to be consistent with Entities correction filings Aug 22, 2023
@seeker25 seeker25 changed the title 17348 - Change SR correction to be consistent with Entities correction filings 17348 - Change SR correction to be consistent with other correction filings Aug 22, 2023
Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs more changes to combine the correction + specialResolutionApplicationCorrection pdfs

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jxio Jxio merged commit bac1659 into bcgov:main Aug 25, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants