Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18052 added agm extension fee codes and tests #2237

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

PaulGarewal
Copy link
Contributor

Issue #: /bcgov/entity#18052

Description of changes:

  • Added AGM extension fee codes
  • Updated relevant tests for agm extension fee codes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2237 (1a24b30) into main (fec0862) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   77.03%   77.00%   -0.04%     
==========================================
  Files         161      161              
  Lines        9838     9844       +6     
  Branches     1660     1662       +2     
==========================================
+ Hits         7579     7580       +1     
- Misses       1801     1806       +5     
  Partials      458      458              
Flag Coverage Δ
legalapi 77.00% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/core/meta/filing.py 90.55% <ø> (ø)
legal-api/src/legal_api/models/filing.py 92.41% <ø> (ø)

... and 1 file with indirect coverage changes

@PaulGarewal PaulGarewal merged commit c2e4af6 into bcgov:main Oct 16, 2023
8 of 9 checks passed
@PaulGarewal PaulGarewal deleted the 18052-AGM-fee-codes-extension branch October 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants