Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18284: digital business card #2256

Closed
wants to merge 14 commits into from

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Oct 19, 2023

Issue #: bcgov/entity#18284

NOTE: do not merge until we determine whether this should be merged in a release branch.

Target release: Entities Sprint 19.3b Release - Digital Credentials

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
legal-api/requirements.txt Outdated Show resolved Hide resolved
Signed-off-by: Akiff Manji <amanji@petridish.dev>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

BUSINESS_SCHEMA_NAME = os.getenv('BUSINESS_SCHEMA_NAME')
BUSINESS_SCHEMA_VERSION = os.getenv('BUSINESS_SCHEMA_VERSION')
BUSINESS_SCHEMA_ID = os.getenv('BUSINESS_SCHEMA_ID')
BUSINESS_CRED_DEF_ID = os.getenv('BUSINESS_CRED_DEF_ID')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where these come from (for the BE) but probably need to work with Patrick Wei to configure these (in 1Password, I assume).

Are there different values for Dev/Test/Prod environments?

Also, where are these key values for running locally?

@severinbeauvais severinbeauvais changed the title feat: digital business card 18284: digital business card Oct 23, 2023
@amanji
Copy link
Contributor Author

amanji commented Oct 25, 2023

Closing as new PR created: #2260

@amanji amanji closed this Oct 25, 2023
@severinbeauvais
Copy link
Collaborator

You probably didn't need to close this PR. I think you could have clicked the Edit button at the top right and just changed the base.

@amanji amanji deleted the feature/digital-business-card branch November 3, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants