Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18281 implement black #2286

Merged
merged 2 commits into from
Oct 31, 2023
Merged

18281 implement black #2286

merged 2 commits into from
Oct 31, 2023

Conversation

thorwolpert
Copy link
Collaborator

Issue #: /bcgov/entity#18281

Description of changes:

  • used black to reformat business-registry-model
  • used black to reforms entity-filer
  • corrected issues from formatting and minor model changes
  • Added NAICS fields to AlternateNames
  • Added Registration date to AlternateNames

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@thorwolpert thorwolpert requested a review from argush3 October 30, 2023 22:43
@thorwolpert thorwolpert marked this pull request as ready for review October 30, 2023 22:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thorwolpert thorwolpert self-assigned this Oct 30, 2023
argush3
argush3 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Black formatting is very generous with space :) But I think I like it. Easier to read.

@thorwolpert thorwolpert merged commit de40772 into bcgov:dev_legal_name_changes Oct 31, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argush3 argush3 argush3 approved these changes

Assignees

@thorwolpert thorwolpert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorwolpert @argush3