Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: digital business card #2290

Merged
merged 37 commits into from
Nov 3, 2023
Merged

feat: digital business card #2290

merged 37 commits into from
Nov 3, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Nov 3, 2023

Issue #: bcgov/entity#18284 + bcgov/entity#18394

Description of changes: See PR #2281 + PR #2287

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

amanji and others added 30 commits October 25, 2023 15:16
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: issue credentials through Traction tenant

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: app initialization workflow

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use out-of-band invitation for connecting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use v2.0 for issuing credential

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: web socket implmentation with flask-socketio

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: db migration script to enable revocation

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: revocation endpoint

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: replace endpoints

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update requirements

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: traction token exchanger

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: ws cors setting is a config option

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: clean up init in digital credential service

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: issue credentials through Traction tenant

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: app initialization workflow

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use out-of-band invitation for connecting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use v2.0 for issuing credential

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: web socket implmentation with flask-socketio

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: db migration script to enable revocation

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: revocation endpoint

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: replace endpoints

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update requirements

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: traction token exchanger

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: ws cors setting is a config option

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: clean up init in digital credential service

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: endpoints to reset credential offers

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: credential id lookup table

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add business roles

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix tests and linting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>
amanji and others added 7 commits November 1, 2023 00:08
Signed-off-by: Akiff Manji <amanji@petridish.dev>
This reverts commit 79a2631.

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
This reverts commit 9763a17.

Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: hard code digital business card schema

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: issue credentials through Traction tenant

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: app initialization workflow

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use out-of-band invitation for connecting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: use v2.0 for issuing credential

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: web socket implmentation with flask-socketio

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: db migration script to enable revocation

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: revocation endpoint

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: replace endpoints

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update requirements

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: traction token exchanger

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update workflow variables

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: ws cors setting is a config option

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: clean up init in digital credential service

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: endpoints to reset credential offers

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: credential id lookup table

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add business roles

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix tests and linting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: remove records from Traction on deletion

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* Revert "feat: web socket implmentation with flask-socketio"

This reverts commit 79a2631.

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: port so it doesnt overlap with airplay server on OSX

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* Revert "fix: port so it doesnt overlap with airplay server on OSX"

This reverts commit 9763a17.

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Copy link

gitguardian bot commented Nov 3, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret fd96a6e legal-api/tests/unit/models/test_dc_definition.py View secret
- Generic High Entropy Secret fc6c34a legal-api/tests/unit/models/test_dc_definition.py View secret
7220870 Generic High Entropy Secret 6beb1b1 legal-api/tests/unit/models/test_dc_definition.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

BUSINESS_SCHEMA_ID: test_business_schema_id
BUSINESS_CRED_DEF_ID: test_credential_definition_id
BUSINESS_SCHEMA_NAME: digital_business_card
BUSINESS_SCHEMA_VERSION: "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the BUSINESS_SCHEMA_ID and BUSINESS_CRED_DEF_ID values for Test and Prod yet? If so, please email them to me and I can put them in 1Password. If not, how do we get them?

Copy link
Collaborator

@severinbeauvais severinbeauvais Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there are 4 5 TRACTION_xxx keys that are not yet configured in Test and Prod.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2290 (fc6c34a) into main (79511cd) will decrease coverage by 1.25%.
Report is 6 commits behind head on main.
The diff coverage is 49.13%.

@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   77.37%   76.12%   -1.25%     
==========================================
  Files         202      163      -39     
  Lines       11602    10092    -1510     
  Branches     1961     1694     -267     
==========================================
- Hits         8977     7683    -1294     
+ Misses       2043     1941     -102     
+ Partials      582      468     -114     
Flag Coverage Δ
entityfiler ?
legalapi 76.12% <49.13%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/config.py 95.16% <100.00%> (+0.28%) ⬆️
legal-api/src/legal_api/models/__init__.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/models/dc_definition.py 90.69% <100.00%> (ø)
...gal_api/services/filings/validations/alteration.py 83.01% <100.00%> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
...l_api/models/dc_issued_business_user_credential.py 94.44% <94.44%> (ø)
legal-api/src/legal_api/models/dc_connection.py 87.50% <33.33%> (-1.39%) ⬇️
...egal-api/src/legal_api/resources/v2/namerequest.py 28.57% <0.00%> (ø)
...l-api/src/legal_api/models/dc_issued_credential.py 82.69% <50.00%> (-5.12%) ⬇️
legal-api/src/legal_api/reports/report.py 26.19% <12.50%> (-0.17%) ⬇️
... and 3 more

... and 41 files with indirect coverage changes

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for Argus' review before merging.

@argush3 argush3 merged commit 2ee5b9a into bcgov:main Nov 3, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants